Skip to content

Add validation for public IP addresses #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
biancarosa opened this issue Feb 28, 2022 · 0 comments · Fixed by #245
Closed

Add validation for public IP addresses #202

biancarosa opened this issue Feb 28, 2022 · 0 comments · Fixed by #245
Labels
enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months

Comments

@biancarosa
Copy link

While looking at the IPV4 validator, it looks like we could benefit to a validation using the https://docs.python.org/3/library/ipaddress.html#ipaddress.IPv4Address.is_private function to check if the IPAddress provided is public or not.

I was thinking of a kwarg named public just like the one used on the URL validator. Does that sound useful?
@yozachar yozachar added enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months labels Mar 10, 2023
@yozachar yozachar mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issue/PR: A new feature outdated Issue/PR: Open for more than 3 months
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

maint: improves url module yozachar/pyvalidators
2 participants
@biancarosa @yozachar