Skip to content

0.28.2 sdist is missing src/validators/_tld.txt #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgorny opened this issue May 25, 2024 · 2 comments
Closed

0.28.2 sdist is missing src/validators/_tld.txt #380

mgorny opened this issue May 25, 2024 · 2 comments
Labels
duplicate Issue/PR: Redundant

Comments

@mgorny
Copy link

mgorny commented May 25, 2024

When trying to run the tests from 0.28.2 sdist, I'm getting lots of test failures like:

FAILED tests/test_domain.py::test_returns_true_on_valid_top_level_domain[example.com-True-False-False] - FileNotFoundError: [Errno 2] No such file or directory: '/tmp/portage/dev-python/validators-0.28.2/work/validators-0.28.2/src/validators/_tld.txt'

Apparently the file was there in 0.28.1 but disappeared in 0.28.2.
@yozachar
Copy link
Collaborator

Hi it was fixed in #379. Please use version 0.28.3.

@yozachar yozachar added the duplicate Issue/PR: Redundant label May 25, 2024
@mgorny
Copy link
Author

mgorny commented May 25, 2024

Thanks! I can confirm that 0.28.3 looks good.

@mgorny mgorny closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Issue/PR: Redundant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgorny @yozachar