Skip to content

Commit 52800b1

Browse files
committed
randr: inherit XError in error classes
Commit c87624d ('Add Randr error classes and register them during init') introduces three new error classes to xrandr, but makes them inherit from Exception. Let all error classes in randr inherit from Xerror, like all other code expects. Fixes the traceback ``` ... File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 182, in sync self.get_pointer_control() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 833, in get_pointer_control return request.GetPointerControl(display = self.display) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1369, in __init__ self.reply() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1381, in reply self._display.send_and_recv(request = self._serial) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 612, in send_and_recv gotreq = self.parse_response(request) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 719, in parse_response gotreq = self.parse_error_response(request) or gotreq File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 745, in parse_error_response req = self.get_waiting_request(e.sequence_number) AttributeError: 'BadRRModeError' object has no attribute 'sequence_number' ``` fixes #241
1 parent 4e8bbf8 commit 52800b1

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Xlib/ext/randr.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636

3737
from Xlib import X
3838
from Xlib.protocol import rq
39+
from Xlib.error import XError
3940

4041
extname = 'RANDR'
4142

@@ -123,11 +124,11 @@
123124
BadRRMode = 2
124125

125126
# Error classes #
126-
class BadRROutputError(Exception): pass
127+
class BadRROutputError(XError): pass
127128

128-
class BadRRCrtcError(Exception): pass
129+
class BadRRCrtcError(XError): pass
129130

130-
class BadRRModeError(Exception): pass
131+
class BadRRModeError(XError): pass
131132

132133
# Data Structures #
133134

0 commit comments

Comments
 (0)