Skip to content

Commit f1375eb

Browse files
committed
randr: inherit XError in error classes
Commit c87624d ('Add Randr error classes and register them during init') introduces three new error classes to xrandr, but makes them inherit from Exception. Let all error classes in randr inherit from Xerror, like all other code expects. Fixes the traceback ``` ... File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 182, in sync self.get_pointer_control() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/display.py", line 833, in get_pointer_control return request.GetPointerControl(display = self.display) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1369, in __init__ self.reply() File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/rq.py", line 1381, in reply self._display.send_and_recv(request = self._serial) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 612, in send_and_recv gotreq = self.parse_response(request) File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 719, in parse_response gotreq = self.parse_error_response(request) or gotreq File "/tmp/python-env/lib/python3.8/site-packages/Xlib/protocol/display.py", line 745, in parse_error_response req = self.get_waiting_request(e.sequence_number) AttributeError: 'BadRRModeError' object has no attribute 'sequence_number' ``` fixes #241
1 parent 333fbcb commit f1375eb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Xlib/ext/randr.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
from tkinter import W
3838
from Xlib import X
3939
from Xlib.protocol import rq, structs
40+
from Xlib.error import XError
4041

4142
extname = 'RANDR'
4243

@@ -124,11 +125,11 @@
124125
BadRRMode = 2
125126

126127
# Error classes #
127-
class BadRROutputError(Exception): pass
128+
class BadRROutputError(XError): pass
128129

129-
class BadRRCrtcError(Exception): pass
130+
class BadRRCrtcError(XError): pass
130131

131-
class BadRRModeError(Exception): pass
132+
class BadRRModeError(XError): pass
132133

133134
# Data Structures #
134135

0 commit comments

Comments
 (0)