compiler/natives/src/encoding/gob: Skip TestTypeRace.

dmitshur · dmitshur · commit 0bd5ec1a0c9e · 2018-02-16T18:04:23.000-05:00
TestTypeRace was added in Go 1.10, and it needs to be skipped because it relies on sync.WaitGroup to behave correctly under concurrency. However, encoding/gob is currently configured to use nosync, which cannot succeed. Since this is a new test, opt to skip it for now rather than making it succeed by replacing nosync with sync. Related to golang/go@1a9f27d. Fixes: === RUN TestTypeRace --- FAIL: TestTypeRace (0.00s) Error: sync: WaitGroup counter not zero FAIL encoding/gob 3.030s
diff --git a/compiler/natives/src/encoding/gob/gob_test.go b/compiler/natives/src/encoding/gob/gob_test.go
@@ -98,3 +98,9 @@ func TestEndToEnd(t *testing.T) {
 		t.Errorf("nil map received")
 	}
 }
+
+func TestTypeRace(t *testing.T) {
+	// encoding/gob currently uses nosync. This test uses sync.WaitGroup and
+	// cannot succeed when nosync is used.
+	t.Skip("using nosync")
+}

Original file line number	Diff line number	Diff line change
`@@ -98,3 +98,9 @@ func TestEndToEnd(t *testing.T) {`
`98`	`98`	`t.Errorf("nil map received")`
`99`	`99`	`}`
`100`	`100`	`}`
	`101`	`+`
	`102`	`+func TestTypeRace(t *testing.T) {`
	`103`	`+ // encoding/gob currently uses nosync. This test uses sync.WaitGroup and`
	`104`	`+ // cannot succeed when nosync is used.`
	`105`	`+ t.Skip("using nosync")`
	`106`	`+}`