Revert "compiler/natives/src/reflect: Return true in IsNil for implicitly converted nil interface."

dmitshur · dmitshur · commit 5e5d2d2a995b · 2018-02-16T18:12:25.000-05:00
This reverts commit 1fb1aaa. The change in that commit was not a complete and correct solution. Instead of resolving the underlying problem, it masked a symptom, allowing the TestCallConvert test to pass. A better fix will follow next.
diff --git a/compiler/natives/src/reflect/reflect.go b/compiler/natives/src/reflect/reflect.go
@@ -924,7 +924,7 @@ func (v Value) Elem() Value {
 	switch k := v.kind(); k {
 	case Interface:
 		val := v.object()
-		if val == js.Global.Get("$ifaceNil") { // TODO: Do we need to check for val == js.InternalObject(0) here?
+		if val == js.Global.Get("$ifaceNil") {
 			return Value{}
 		}
 		typ := reflectType(val.Get("constructor"))
@@ -1108,7 +1108,7 @@ func (v Value) IsNil() bool {
 	case Map:
 		return v.object() == js.InternalObject(false)
 	case Interface:
-		return v.object() == js.Global.Get("$ifaceNil") || v.object() == js.InternalObject(0)
+		return v.object() == js.Global.Get("$ifaceNil")
 	default:
 		panic(&ValueError{"reflect.Value.IsNil", k})
 	}
