Skip to content

Commit 7c7c569

Browse files
committed
tests: Triage test failures new to Go 1.10.
1 parent 397649b commit 7c7c569

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

tests/run.go

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ var knownFails = map[string]failReason{
8282

8383
// These are new tests in Go 1.7.
8484
"fixedbugs/issue14646.go": {category: unsureIfGopherJSSupportsThisFeature, desc: "tests runtime.Caller behavior in a deferred func in SSA backend... does GopherJS even support runtime.Caller?"},
85-
"fixedbugs/issue15039.go": {category: validButDealWithAfterGo17SinceNew, desc: "valid bug but deal with after Go 1.7 support is out? it's likely not a regression"},
86-
"fixedbugs/issue15281.go": {category: validButDealWithAfterGo17SinceNew, desc: "also looks valid but deal with after Go 1.7 support is out? it's likely not a regression"},
87-
"fixedbugs/issue15975.go": {category: validButDealWithAfterGo17SinceNew, desc: "also looks valid but deal with after Go 1.7 support is out?"},
85+
"fixedbugs/issue15039.go": {desc: "valid bug but deal with after Go 1.7 support is out? it's likely not a regression"},
86+
"fixedbugs/issue15281.go": {desc: "also looks valid but deal with after Go 1.7 support is out? it's likely not a regression"},
87+
"fixedbugs/issue15975.go": {desc: "also looks valid but deal with after Go 1.7 support is out?"},
8888

8989
// These are new tests in Go 1.8.
9090
"fixedbugs/issue15528.go": {category: usesUnsupportedPackage, desc: `imports "unsafe" package and gets: Error: reflect: call of reflect.Value.IsNil on unsafe.Pointer Value`}, // See https://github.com/golang/go/commit/dfc56a4cd313c9c5de37f4fadb14912286edc42f for relevant commit.
@@ -98,6 +98,13 @@ var knownFails = map[string]failReason{
9898
want:
9999
"value method main.T.F called using nil *T pointer"`},
100100
"fixedbugs/issue19246.go": {desc: "expected nil pointer dereference panic"}, // Issue https://golang.org/issues/19246: Failed to evaluate some zero-sized values when converting them to interfaces.
101+
102+
// These are new tests in Go 1.10.
103+
"fixedbugs/issue21879.go": {desc: "incorrect output related to runtime.Callers, runtime.CallersFrames, etc."},
104+
"fixedbugs/issue21887.go": {desc: "incorrect output (although within spec, not worth fixing) for println(^uint64(0)). got: { '$high': 4294967295, '$low': 4294967295, '$val': [Circular] } want: 18446744073709551615"},
105+
"fixedbugs/issue22083.go": {category: requiresSourceMapSupport}, // Technically, added in Go 1.9.2.
106+
"fixedbugs/issue22660.go": {category: notApplicable, desc: "test of gc compiler, uses os/exec.Command"},
107+
"fixedbugs/issue23305.go": {desc: "GopherJS fails to compile println(0xffffffff), maybe because 32-bit arch"},
101108
}
102109

103110
type failCategory uint8
@@ -109,7 +116,7 @@ const (
109116
requiresSourceMapSupport // Test fails without source map support (as configured in CI), because it tries to check filename/line number via runtime.Caller.
110117
compilerPanic
111118
unsureIfGopherJSSupportsThisFeature
112-
validButDealWithAfterGo17SinceNew // TODO: After Go 1.7 support is out, this category should be re-triaged and removed.
119+
notApplicable // Test that doesn't need to run under GopherJS; it doesn't apply to the Go language in a general way.
113120
)
114121

115122
type failReason struct {

0 commit comments

Comments
 (0)