Updated to fix a bug

jhughes1153 · jhughes1153 · commit a8ff476738ad · 2020-05-17T13:06:03.000-04:00
diff --git a/argparse_test.go b/argparse_test.go
@@ -856,6 +856,54 @@ func TestIntFailSimple1(t *testing.T) {
 	}
 }
 
+func TestEqualIntFailSimple1(t *testing.T) {
+	testArgs := []string{"progname", "--flag-arg1=string"}
+
+	p := NewParser("", "description")
+	i1 := p.Int("f", "flag-arg1", nil)
+
+	err := p.Parse(testArgs)
+	errStr := "[-f|--flag-arg1] bad integer value [string]"
+	if err == nil || err.Error() != errStr {
+		t.Errorf("Test %s expected [%s], got [%+v]", t.Name(), errStr, err)
+		return
+	}
+
+	if i1 == nil {
+		t.Errorf("Test %s failed with flag1 being nil pointer", t.Name())
+		return
+	}
+
+	if *i1 != 0 {
+		t.Errorf("Test %s failed. Want: [0], got: [%d]", t.Name(), *i1)
+		return
+	}
+}
+
+func TestEqualNoValFailSimple(t *testing.T) {
+	testArgs := []string{"progname", "--flag-arg1="}
+
+	p := NewParser("", "description")
+	i1 := p.Int("f", "flag-arg1", nil)
+
+	err := p.Parse(testArgs)
+	errStr := "not enough arguments for -f|--flag-arg1"
+	if err == nil || err.Error() != errStr {
+		t.Errorf("Test %s expected [%s], got [%+v]", t.Name(), errStr, err)
+		return
+	}
+
+	if i1 == nil {
+		t.Errorf("Test %s failed with flag1 being nil pointer", t.Name())
+		return
+	}
+
+	if *i1 != 0 {
+		t.Errorf("Test %s failed. Want: [0], got: [%d]", t.Name(), *i1)
+		return
+	}
+}
+
 func TestFileAddArgumentFail(t *testing.T) {
 	type testCase struct {
 		testName, shortArg, longArg, failureMessage string
diff --git a/command.go b/command.go
@@ -87,7 +87,7 @@ func (o *Command) parseArguments(args *[]string) error {
 				if cnt, err := oarg.check(equalArg[0]); err != nil {
 					return err
 				} else if cnt > 0 {
-					if len(equalArg) < 2 {
+					if equalArg[1] == "" {
 						return fmt.Errorf("not enough arguments for %s", oarg.name())
 					}
 					oarg.eqChar = true

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ func (o Command) parseArguments(args []string) error {`
`87`	`87`	`if cnt, err := oarg.check(equalArg[0]); err != nil {`
`88`	`88`	`return err`
`89`	`89`	`} else if cnt > 0 {`
`90`		`- if len(equalArg) < 2 {`
	`90`	`+ if equalArg[1] == "" {`
`91`	`91`	`return fmt.Errorf("not enough arguments for %s", oarg.name())`
`92`	`92`	`}`
`93`	`93`	`oarg.eqChar = true`