Merge pull request #2 from adilrizvi/iterable-input

pythonhacker · web-flow · commit 0f8ea82c65f4 · 2017-03-27T15:21:02.000+05:30
iterable input for commonprefix
diff --git a/idioms.py b/idioms.py
@@ -159,19 +159,26 @@ def flatten(iterables):
         else:
             yield i
 
-def commonprefix(*instrings):
+def commonprefix(iterable, ignore_case=False):
     """ Common prefix of input strings using OrderedDict
 
-    >>> commonprefix('Python','Pythonista')
+    >>> commonprefix(['Python','Pythonista'])
     'Python'
-    >>> commonprefix('Persia','Person','Perl','Perlite')
+    >>> commonprefix(('Persia','Person','Perl','Perlite'))
     'Per'
-    >>> commonprefix('Batman', 'Battleship','Batista','Bat')
-    'Bat'
-    
+    >>> commonprefix(['rambo', 'Rambo'], ignore_case=True)
+    'rambo'
     """
     
     d = collections.OrderedDict()
+
+    if isinstance(iterable, collections.Iterable):
+        instrings = iterable
+    else:
+        raise Exception("Only Iterables are allowed as an Input")
+
+    # adjusting input strings according to the ignore_case option
+    instrings = map(str.lower, instrings) if ignore_case else instrings
     
     for instring in instrings:
         for idx,char in enumerate(instring):
