Skip to content

Commit e5b84e7

Browse files
author
Steve Canny
committed
api: remove old Document.save()
1 parent 6c9d5de commit e5b84e7

File tree

2 files changed

+1
-36
lines changed

2 files changed

+1
-36
lines changed

docx/api.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,7 @@ def part(self):
8585
return self._document.part
8686

8787
def save(self, path_or_stream):
88-
"""
89-
Save this document to *path_or_stream*, which can be either a path to
90-
a filesystem location (a string) or a file-like object.
91-
"""
92-
self._package.save(path_or_stream)
88+
self._document.save(path_or_stream)
9389

9490
@property
9591
def sections(self):

tests/test_api.py

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,7 @@
1616
from docx.opc.constants import CONTENT_TYPE as CT
1717
from docx.package import Package
1818
from docx.parts.document import DocumentPart, InlineShapes
19-
from docx.section import Section
2019
from docx.styles.styles import Styles
21-
from docx.text.run import Run
2220

2321
from .unitutil.mock import (
2422
function_mock, instance_mock, class_mock, property_mock
@@ -95,28 +93,13 @@ def it_provides_access_to_the_document_tables(self, tables_fixture):
9593
tables = document.tables
9694
assert tables is tables_
9795

98-
def it_can_save_the_package(self, save_fixture):
99-
document, package_, file_ = save_fixture
100-
document.save(file_)
101-
package_.save.assert_called_once_with(file_)
102-
10396
def it_provides_access_to_its_styles(self, styles_fixture):
10497
document, styles_ = styles_fixture
10598
styles = document.styles
10699
assert styles is styles_
107100

108101
# fixtures -------------------------------------------------------
109102

110-
@pytest.fixture
111-
def init_fixture(self, docx_, open_):
112-
return docx_, open_
113-
114-
@pytest.fixture
115-
def save_fixture(self, request, open_, package_):
116-
file_ = instance_mock(request, str)
117-
document = Document()
118-
return document, package_, file_
119-
120103
@pytest.fixture
121104
def styles_fixture(self, document, styles_):
122105
document._document_part.styles = styles_
@@ -163,26 +146,12 @@ def open_(self, request, document_obj_, document_part_, package_):
163146
return_value=document_obj_
164147
)
165148

166-
@pytest.fixture
167-
def Package_(self, request, package_):
168-
Package_ = class_mock(request, 'docx.api.Package')
169-
Package_.open.return_value = package_
170-
return Package_
171-
172149
@pytest.fixture
173150
def package_(self, request, document_part_):
174151
package_ = instance_mock(request, Package)
175152
package_.main_document_part = document_part_
176153
return package_
177154

178-
@pytest.fixture
179-
def run_(self, request):
180-
return instance_mock(request, Run)
181-
182-
@pytest.fixture
183-
def section_(self, request):
184-
return instance_mock(request, Section)
185-
186155
@pytest.fixture
187156
def styles_(self, request):
188157
return instance_mock(request, Styles)

0 commit comments

Comments
 (0)