PythonException.StackTrace is GIL-safe

lostmsu · lostmsu · commit 00653dcf9a72 · 2021-04-09T12:40:58.000-07:00
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -268,8 +268,15 @@ public void Restore()
         /// A string representing the python exception stack trace.
         /// </remarks>
         public override string StackTrace
-            => (Traceback is null ? "" : TracebackToString(Traceback))
-               + base.StackTrace;
+        {
+            get
+            {
+                if (Traceback is null) return base.StackTrace;
+
+                using var _ = new Py.GILState();
+                return TracebackToString(Traceback) + base.StackTrace;
+            }
+        }
 
         public override string Message => GetMessage();
 
