fixed type of reference in PyException_SetCause

lostmsu · lostmsu · commit 146ebf3f3d06 · 2021-04-10T20:06:24.000-07:00
diff --git a/src/runtime/exceptions.cs b/src/runtime/exceptions.cs
@@ -295,7 +295,7 @@ public static void SetCause(Exception cause)
             var currentException = PythonException.FetchCurrentRaw();
             currentException.Normalize();
             using var causeInstance = Converter.ToPythonReference(cause);
-            Runtime.PyException_SetCause(currentException.Value.Reference, causeInstance);
+            Runtime.PyException_SetCause(currentException.Value!.Reference, causeInstance.Steal());
             currentException.Restore();
         }
 
@@ -392,7 +392,9 @@ internal static IntPtr RaiseTypeError(string message)
             var typeError = PythonException.FetchCurrentRaw();
             typeError.Normalize();
 
-            Runtime.PyException_SetCause(typeError.Value.Reference, cause.Value.Reference);
+            Runtime.PyException_SetCause(
+                typeError.Value!.Reference,
+                new NewReference(cause.Value!.Reference).Steal());
             typeError.Restore();
 
             return IntPtr.Zero;
diff --git a/src/runtime/runtime.cs b/src/runtime/runtime.cs
@@ -2112,7 +2112,7 @@ internal static NewReference PyException_GetTraceback(BorrowedReference ex)
         /// <summary>
         /// Set the cause associated with the exception to cause. Use NULL to clear it. There is no type check to make sure that cause is either an exception instance or None. This steals a reference to cause.
         /// </summary>
-        internal static void PyException_SetCause(BorrowedReference ex, BorrowedReference cause)
+        internal static void PyException_SetCause(BorrowedReference ex, StolenReference cause)
             => Delegates.PyException_SetCause(ex, cause);
         internal static int PyException_SetTraceback(BorrowedReference ex, BorrowedReference tb)
             => Delegates.PyException_SetTraceback(ex, tb);
@@ -2516,7 +2516,7 @@ static Delegates()
                 PyDict_GetItemWithError = (delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, BorrowedReference>)GetFunctionByName(nameof(PyDict_GetItemWithError), GetUnmanagedDll(_PythonDll));
                 PyException_GetCause = (delegate* unmanaged[Cdecl]<BorrowedReference, NewReference>)GetFunctionByName(nameof(PyException_GetCause), GetUnmanagedDll(_PythonDll));
                 PyException_GetTraceback = (delegate* unmanaged[Cdecl]<BorrowedReference, NewReference>)GetFunctionByName(nameof(PyException_GetTraceback), GetUnmanagedDll(_PythonDll));
-                PyException_SetCause = (delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, void>)GetFunctionByName(nameof(PyException_SetCause), GetUnmanagedDll(_PythonDll));
+                PyException_SetCause = (delegate* unmanaged[Cdecl]<BorrowedReference, StolenReference, void>)GetFunctionByName(nameof(PyException_SetCause), GetUnmanagedDll(_PythonDll));
                 PyException_SetTraceback = (delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, int>)GetFunctionByName(nameof(PyException_SetTraceback), GetUnmanagedDll(_PythonDll));
                 PyThreadState_SetAsyncExcLLP64 = (delegate* unmanaged[Cdecl]<uint, IntPtr, int>)GetFunctionByName("PyThreadState_SetAsyncExc", GetUnmanagedDll(_PythonDll));
                 PyThreadState_SetAsyncExcLP64 = (delegate* unmanaged[Cdecl]<ulong, IntPtr, int>)GetFunctionByName("PyThreadState_SetAsyncExc", GetUnmanagedDll(_PythonDll));
@@ -2796,7 +2796,7 @@ static Delegates()
             internal static delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, BorrowedReference> PyDict_GetItemWithError { get; }
             internal static delegate* unmanaged[Cdecl]<BorrowedReference, NewReference> PyException_GetCause { get; }
             internal static delegate* unmanaged[Cdecl]<BorrowedReference, NewReference> PyException_GetTraceback { get; }
-            internal static delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, void> PyException_SetCause { get; }
+            internal static delegate* unmanaged[Cdecl]<BorrowedReference, StolenReference, void> PyException_SetCause { get; }
             internal static delegate* unmanaged[Cdecl]<BorrowedReference, BorrowedReference, int> PyException_SetTraceback { get; }
             internal static delegate* unmanaged[Cdecl]<uint, IntPtr, int> PyThreadState_SetAsyncExcLLP64 { get; }
             internal static delegate* unmanaged[Cdecl]<ulong, IntPtr, int> PyThreadState_SetAsyncExcLP64 { get; }
