Call msbuild only on Mono in shell mode

davidanthoff · davidanthoff · commit 68a3f2f2ce13 · 2014-03-18T21:41:13.000-07:00
diff --git a/pythonnet/setup.py b/pythonnet/setup.py
@@ -99,8 +99,8 @@ def build_extension(self, ext):
         ]
 
         self.announce("Building: %s" % " ".join(cmd))
-        check_call(" ".join(cmd) + " /t:Clean", shell=True)
-        check_call(" ".join(cmd) + " /t:Build", shell=True)
+        check_call(" ".join(cmd + ["/t:Clean"]), shell=(True if DEVTOOLS=="Mono" else False))
+        check_call(" ".join(cmd + ["/t:Build"]), shell=(True if DEVTOOLS=="Mono" else False))
 
         if DEVTOOLS == "Mono":
             self._build_monoclr(ext)

Original file line number	Diff line number	Diff line change
`@@ -99,8 +99,8 @@ def build_extension(self, ext):`
`99`	`99`	`]`
`100`	`100`
`101`	`101`	`self.announce("Building: %s" % " ".join(cmd))`
`102`		`- check_call(" ".join(cmd) + " /t:Clean", shell=True)`
`103`		`- check_call(" ".join(cmd) + " /t:Build", shell=True)`
	`102`	`+ check_call(" ".join(cmd + ["/t:Clean"]), shell=(True if DEVTOOLS=="Mono" else False))`
	`103`	`+ check_call(" ".join(cmd + ["/t:Build"]), shell=(True if DEVTOOLS=="Mono" else False))`
`104`	`104`
`105`	`105`	`if DEVTOOLS == "Mono":`
`106`	`106`	`self._build_monoclr(ext)`