Skip to content

Commit 88b3d27

Browse files
committed
Use stream position instead of counting read bytes.
FileStream.Read returns (bytes read, buffer), not just bytes read as the buffer is passed by reference. This is a bit unintuative, but checking the position is clear and less error prone.
1 parent 9f562be commit 88b3d27

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

demo/wordpad.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -316,11 +316,10 @@ def OpenDocument(self):
316316

317317
buff = System.Array.CreateInstance(System.Byte, 1024)
318318
data = []
319-
read = -1
320319

321-
while (read != 0):
320+
while stream.Position < stream.Length:
322321
buff.Initialize()
323-
read = stream.Read(buff, 0, 1024)
322+
stream.Read(buff, 0, 1024)
324323
temp = Encoding.ASCII.GetString(buff, 0, 1024)
325324
data.append(temp)
326325

0 commit comments

Comments
 (0)