=Avoid converting ObservableCollection<T> into python list

fdv1 · fdv1 · commit b080f497dc30 · 2018-11-11T21:59:11.000Z
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -5,6 +5,7 @@
 using System.Reflection;
 using System.Runtime.InteropServices;
 using System.Security;
+using System.ComponentModel;
 
 namespace Python.Runtime
 {
@@ -134,8 +135,8 @@ internal static IntPtr ToPython(object value, Type type)
                 return result;
             }
 
-            if (value is IList && value.GetType().IsGenericType)
-            {
+			if (value is IList && !(value is INotifyPropertyChanged) && value.GetType().IsGenericType)
+			{
                 using (var resultlist = new PyList())
                 {
                     foreach (object o in (IEnumerable)value)

Original file line number	Diff line number	Diff line change
`@@ -5,6 +5,7 @@`
`5`	`5`	`using System.Reflection;`
`6`	`6`	`using System.Runtime.InteropServices;`
`7`	`7`	`using System.Security;`
	`8`	`+using System.ComponentModel;`
`8`	`9`
`9`	`10`	`namespace Python.Runtime`
`10`	`11`	`{`
`@@ -134,8 +135,8 @@ internal static IntPtr ToPython(object value, Type type)`
`134`	`135`	`return result;`
`135`	`136`	`}`
`136`	`137`
`137`		`- if (value is IList && value.GetType().IsGenericType)`
`138`		`- {`
	`138`	`+ if (value is IList && !(value is INotifyPropertyChanged) && value.GetType().IsGenericType)`
	`139`	`+ {`
`139`	`140`	`using (var resultlist = new PyList())`
`140`	`141`	`{`
`141`	`142`	`foreach (object o in (IEnumerable)value)`