Reverse Python traceback to match C# stacktrace order

filmor · filmor · commit ce61a6f3b4c0 · 2021-01-29T07:45:37.000+01:00
diff --git a/src/runtime/pythonexception.cs b/src/runtime/pythonexception.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Linq;
 using System.Runtime.CompilerServices;
 using System.Text;
 
@@ -44,6 +45,7 @@ public PythonException()
                 }
                 _message = type + " : " + message;
             }
+
             if (_pyTB != IntPtr.Zero)
             {
                 using PyObject tb_module = PythonEngine.ImportModule("traceback");
@@ -54,7 +56,9 @@ public PythonException()
                 using var tbList = tb_module.InvokeMethod("format_tb", pyTB);
 
                 var sb = new StringBuilder();
-                foreach (var line in tbList) {
+                // Reverse Python's traceback list to match the order used in C#
+                // stacktraces
+                foreach (var line in tbList.Reverse()) {
                     sb.Append(line.ToString());
                 }
                 _tb = sb.ToString();

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using System;`
	`2`	`+using System.Linq;`
`2`	`3`	`using System.Runtime.CompilerServices;`
`3`	`4`	`using System.Text;`
`4`	`5`
`@@ -44,6 +45,7 @@ public PythonException()`
`44`	`45`	`}`
`45`	`46`	`_message = type + " : " + message;`
`46`	`47`	`}`
	`48`	`+`
`47`	`49`	`if (_pyTB != IntPtr.Zero)`
`48`	`50`	`{`
`49`	`51`	`using PyObject tb_module = PythonEngine.ImportModule("traceback");`
`@@ -54,7 +56,9 @@ public PythonException()`
`54`	`56`	`using var tbList = tb_module.InvokeMethod("format_tb", pyTB);`
`55`	`57`
`56`	`58`	`var sb = new StringBuilder();`
`57`		`- foreach (var line in tbList) {`
	`59`	`+ // Reverse Python's traceback list to match the order used in C#`
	`60`	`+ // stacktraces`
	`61`	`+ foreach (var line in tbList.Reverse()) {`
`58`	`62`	`sb.Append(line.ToString());`
`59`	`63`	`}`
`60`	`64`	`_tb = sb.ToString();`