Added parameter validation to PyObject methods (#1021)

lostmsu · web-flow · commit dbb88bcede0f · 2020-02-03T12:50:42.000+01:00
* added parameter validation to PyObject methods
diff --git a/src/embed_tests/TestPyObject.cs b/src/embed_tests/TestPyObject.cs
@@ -57,5 +57,11 @@ def add(self, x, y):
                 Assert.IsTrue(memberNames.Contains(expectedName), "Could not find member '{0}'.", expectedName);
             }
         }
+
+        [Test]
+        public void InvokeNull() {
+            var list = PythonEngine.Eval("list");
+            Assert.Throws<ArgumentNullException>(() => list.Invoke(new PyObject[] {null}));
+        }
     }
 }
diff --git a/src/runtime/pyint.cs b/src/runtime/pyint.cs
@@ -62,7 +62,7 @@ public PyInt(int value)
         /// Creates a new Python int from a uint32 value.
         /// </remarks>
         [CLSCompliant(false)]
-        public PyInt(uint value) : base(IntPtr.Zero)
+        public PyInt(uint value)
         {
             obj = Runtime.PyInt_FromInt64(value);
             Runtime.CheckExceptionOccurred();
@@ -75,7 +75,7 @@ public PyInt(uint value) : base(IntPtr.Zero)
         /// <remarks>
         /// Creates a new Python int from an int64 value.
         /// </remarks>
-        public PyInt(long value) : base(IntPtr.Zero)
+        public PyInt(long value)
         {
             obj = Runtime.PyInt_FromInt64(value);
             Runtime.CheckExceptionOccurred();
@@ -89,7 +89,7 @@ public PyInt(long value) : base(IntPtr.Zero)
         /// Creates a new Python int from a uint64 value.
         /// </remarks>
         [CLSCompliant(false)]
-        public PyInt(ulong value) : base(IntPtr.Zero)
+        public PyInt(ulong value)
         {
             obj = Runtime.PyInt_FromInt64((long)value);
             Runtime.CheckExceptionOccurred();
diff --git a/src/runtime/pyobject.cs b/src/runtime/pyobject.cs

Original file line number	Diff line number	Diff line change
`@@ -57,5 +57,11 @@ def add(self, x, y):`
`57`	`57`	`Assert.IsTrue(memberNames.Contains(expectedName), "Could not find member '{0}'.", expectedName);`
`58`	`58`	`}`
`59`	`59`	`}`
	`60`	`+`
	`61`	`+ [Test]`
	`62`	`+ public void InvokeNull() {`
	`63`	`+ var list = PythonEngine.Eval("list");`
	`64`	`+ Assert.Throws<ArgumentNullException>(() => list.Invoke(new PyObject[] {null}));`
	`65`	`+ }`
`60`	`66`	`}`
`61`	`67`	`}`