Only clear dict if tp_dictoffset > 0

filmor · filmor · commit ddf5a701d254 · 2022-10-30T21:36:03.000+01:00
diff --git a/src/runtime/Types/ManagedType.cs b/src/runtime/Types/ManagedType.cs
@@ -148,8 +148,9 @@ protected static void ClearObjectDict(BorrowedReference ob)
         {
             BorrowedReference type = Runtime.PyObject_TYPE(ob);
             int instanceDictOffset = Util.ReadInt32(type, TypeOffset.tp_dictoffset);
-            Debug.Assert(instanceDictOffset > 0);
-            Runtime.Py_CLEAR(ob, instanceDictOffset);
+            // Debug.Assert(instanceDictOffset > 0);
+            if (instanceDictOffset > 0)
+                Runtime.Py_CLEAR(ob, instanceDictOffset);
         }
 
         protected static BorrowedReference GetObjectDict(BorrowedReference ob)

Original file line number	Diff line number	Diff line change
`@@ -148,8 +148,9 @@ protected static void ClearObjectDict(BorrowedReference ob)`
`148`	`148`	`{`
`149`	`149`	`BorrowedReference type = Runtime.PyObject_TYPE(ob);`
`150`	`150`	`int instanceDictOffset = Util.ReadInt32(type, TypeOffset.tp_dictoffset);`
`151`		`- Debug.Assert(instanceDictOffset > 0);`
`152`		`- Runtime.Py_CLEAR(ob, instanceDictOffset);`
	`151`	`+ // Debug.Assert(instanceDictOffset > 0);`
	`152`	`+ if (instanceDictOffset > 0)`
	`153`	`+ Runtime.Py_CLEAR(ob, instanceDictOffset);`
`153`	`154`	`}`
`154`	`155`
`155`	`156`	`protected static BorrowedReference GetObjectDict(BorrowedReference ob)`