fixed missing BorrowedReference.DangerousIncRefOrNull

lostmsu · lostmsu · commit e6efa2f267d9 · 2020-05-16T13:57:37.000-07:00
diff --git a/src/runtime/methodbinding.cs b/src/runtime/methodbinding.cs
@@ -145,7 +145,9 @@ public static IntPtr tp_getattro(IntPtr ob, IntPtr key)
                     {
                         return Runtime.PyObject_GenericGetAttr(ob, key);
                     }
-                    return sig.Reference.DangerousIncRefOrNull();
+                    return sig.Reference.IsNull
+                        ? IntPtr.Zero
+                        : Runtime.SelfIncRef(sig.Reference.DangerousGetAddress());
                 case "__name__":
                     var pyName = self.m.GetName();
                     return pyName == IntPtr.Zero

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,9 @@ public static IntPtr tp_getattro(IntPtr ob, IntPtr key)`
`145`	`145`	`{`
`146`	`146`	`return Runtime.PyObject_GenericGetAttr(ob, key);`
`147`	`147`	`}`
`148`		`- return sig.Reference.DangerousIncRefOrNull();`
	`148`	`+ return sig.Reference.IsNull`
	`149`	`+ ? IntPtr.Zero`
	`150`	`+ : Runtime.SelfIncRef(sig.Reference.DangerousGetAddress());`
`149`	`151`	`case "__name__":`
`150`	`152`	`var pyName = self.m.GetName();`
`151`	`153`	`return pyName == IntPtr.Zero`