Remove superfluous Incref

filmor · web-flow · commit ee6a828eccbd · 2020-05-15T01:15:47.000+02:00
Also drop comment on the type check.
If `PyCell_Set` is not called with a cell it will raise an exception, which is perfectly valid here.
diff --git a/src/runtime/typemanager.cs b/src/runtime/typemanager.cs
@@ -284,11 +284,7 @@ internal static IntPtr CreateSubType(IntPtr py_name, IntPtr py_base_type, IntPtr
                 IntPtr cell = Runtime.PyDict_GetItemString(cls_dict, "__classcell__");
                 if (cell != IntPtr.Zero)
                 {
-                    // if (Runtime.PyObject_TypeCheck(cell, Runtime.PyCellType))
-                    {
-                        Runtime.XIncref(cell);
-                        Runtime.PyCell_Set(cell, py_type);
-                    }
+                    Runtime.PyCell_Set(cell, py_type);
                     Runtime.PyDict_DelItemString(cls_dict, "__classcell__");
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -284,11 +284,7 @@ internal static IntPtr CreateSubType(IntPtr py_name, IntPtr py_base_type, IntPtr`
`284`	`284`	`IntPtr cell = Runtime.PyDict_GetItemString(cls_dict, "__classcell__");`
`285`	`285`	`if (cell != IntPtr.Zero)`
`286`	`286`	`{`
`287`		`- // if (Runtime.PyObject_TypeCheck(cell, Runtime.PyCellType))`
`288`		`- {`
`289`		`- Runtime.XIncref(cell);`
`290`		`- Runtime.PyCell_Set(cell, py_type);`
`291`		`- }`
	`287`	`+ Runtime.PyCell_Set(cell, py_type);`
`292`	`288`	`Runtime.PyDict_DelItemString(cls_dict, "__classcell__");`
`293`	`289`	`}`
`294`	`290`