Skip to content

Clean up code in PyBuffer #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lostmsu opened this issue Sep 14, 2021 · 0 comments · Fixed by #1662
Closed

Clean up code in PyBuffer #1556

lostmsu opened this issue Sep 14, 2021 · 0 comments · Fixed by #1662
Milestone
3.0.0

Comments

@lostmsu
Copy link
Member

lostmsu commented Sep 14, 2021

Needed improvements:

  • finalization looks suspicious
  • input arguments must be validated before passing to Python
@filmor filmor added this to the 3.0.0 milestone Oct 11, 2021
lostmsu added a commit to losttech/pythonnet that referenced this issue Jan 6, 2022
@lostmsu
cleanup PyBuffer a bit:
8b21058 
- better finalizer, that actually calls PyBuffer_Release
- improved input parameter handling for common routines
- added support for copying data to/from large Python buffers

fixes pythonnet#1556
@lostmsu lostmsu mentioned this issue Jan 6, 2022
Merged
1 task
lostmsu added a commit that referenced this issue Jan 6, 2022
@lostmsu
cleanup PyBuffer a bit:
88850f5 
- better finalizer, that actually calls PyBuffer_Release
- improved input parameter handling for common routines
- added support for copying data to/from large Python buffers

fixes #1556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Cleanup PyBuffer a bit losttech/pythonnet
2 participants
@filmor @lostmsu