Skip to content

PyGILState_Ensure - return type correct? #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tom-bowles opened this issue Oct 20, 2021 · 0 comments · Fixed by #1645
Closed

PyGILState_Ensure - return type correct? #1606

tom-bowles opened this issue Oct 20, 2021 · 0 comments · Fixed by #1645
Milestone
3.0.0

Comments

@tom-bowles
Copy link

Apologies if this is a misguided question. It's based on looking at the source code, not any observed misbehaviour.

Is the return type of PyGILState_Ensure correct in Runtime.cs? It returns IntPtr, which is 8 bytes on 64-bit. However, PyGILState_STATE is an enum with 2 members, which comes out as 4 bytes on VC++.
@filmor filmor added this to the 3.0.0 milestone Dec 15, 2021
@filmor filmor mentioned this issue Dec 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Fix the PyGILState_STATE type filmor/pythonnet
2 participants
@filmor @tom-bowles