Seeking Feedback for Potential PR: Method Binder IsAssignable From #529
Comments
|
My python skills are severely lacking, so I'll just ask here. Is there a test that verifies derived types can be passed as arguments to functions? Does pythonnet support invoking the class BaseClass { }
class SubClass : BaseClass { }
static class Method
{
public static void AcceptsBaseClass(BaseClass arg) { }
}Thanks! |
|
@jaredbroad @mhandschuh @AlexCatarino the issue is much deeper. As a starter take a look at this PR which I gave up on merging: For more of overloading stuff have a look at this meta-issue (this is one of my frequent nightmares): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of our team (@mchandschuh) suggested this line could be substituted for a "IsAssignableFrom" check. https://github.com/pythonnet/pythonnet/blob/master/src/runtime/methodbinder.cs#L60
The plan would be to make the generic-locator code more effective.
mhandschuh [4:11 PM]
I would recommend looking at the MethodBinder -- it appears to be matching directly on type and not using
Type.IsAssignableFromwhich should properly handle super types (going from SimpleMovingAverage to IndicatorBase)We're not really sure the flow on impacts for the whole library -- is this feasible; or are other parts of the code dependent on this = statement?
The text was updated successfully, but these errors were encountered: