Skip to content

PR reviews: reduce requirements #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
den-run-ai opened this issue Jan 28, 2018 · 6 comments
Closed

PR reviews: reduce requirements #610

den-run-ai opened this issue Jan 28, 2018 · 6 comments

Comments

@den-run-ai
Copy link
Contributor

den-run-ai commented Jan 28, 2018 •
edited
Loading

I would like to reduce requirements for PR reviews to merge faster the existing and new pull requests:

  1. If the pull request is a small bug fix with tests (if applicable), then only one (1) core developer review is necessary.
  2. If the pull request is a feature or significant change then at least two (2) core developers should review.
  3. If the pull request is from core developers only another (1) core developer review is required unless that reviewer suggests more reviewers.
  4. If the pull request is a small bug fix with tests, then this core developer (author of this fix) can merge this without any reviews.
  5. In the case of conflicts voting is going to be performed.
  6. More PR reviewers without commit rights should be added!
  7. Each release is going to have one release manager to manage which PRs should be included.

@filmor @vmuriart @dmitriyse @tonyroberts @brianlloyd @yagweb @Cronan @AlexCatarino @jaredbroad
@dmitriyse
Copy link
Contributor

Lets try this new rules!

@Cronan
Copy link
Contributor

Cronan commented Jan 29, 2018

Sounds good

@den-run-ai
Copy link
Contributor Author

I'm going forward with these new rules, since no negative is received!

@den-run-ai
Copy link
Contributor Author

Updated in wiki:

https://github.com/pythonnet/pythonnet/wiki/Development-Guidelines

@Cronan Cronan mentioned this issue Feb 8, 2018
Closed
4 tasks
@den-run-ai den-run-ai mentioned this issue Feb 26, 2018
Merged
4 tasks
@den-run-ai
Copy link
Contributor Author

@lostmsu see requirements above for PRs and commits

@den-run-ai den-run-ai reopened this Jun 17, 2019
@filmor
Copy link
Member

filmor commented Nov 8, 2019

No idea why you reopened this :)

@filmor filmor closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@filmor @Cronan @den-run-ai @dmitriyse