Reworked Enum marshaling #1392
Merged
Reworked Enum marshaling #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c00ae2b to
429cc3b
Compare
429cc3b to
9bff356
Compare
48655d8 to
f77b131
Compare
- enums are no longer converted to and from PyLong automatically pythonnet#1220 - one can construct an instance of MyEnum from Python using MyEnum(numeric_val), e.g. MyEnum(10) - in the above, if MyEnum does not have [Flags] and does not have value 10 defined, to create MyEnum with value 10 one must call MyEnum(10, True). Here True is an unnamed parameter, that allows unchecked conversion - legacy behavior has been moved to a codec (EnumPyLongCodec); enums can now be encoded by codecs - flags enums support bitwise ops via EnumOps class
f77b131 to
5c41499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
PyLongautomatically .NET enums should not be automatically converted to Python int and back #1220MyEnumfrom Python usingMyEnum(numeric_val), e.g.MyEnum(10)MyEnumdoes not have[Flags]and does not have member with value10defined, to createMyEnumwith value10one must callMyEnum(10, True). HereTrueis an unnamed parameter, that allows unchecked conversionEnumPyLongCodec; enums can now be encoded by codecsEnumOpsclass, that implements bitwise operations on[Flags]enums.Does this close any currently open issues?
#1220
Checklist
Check all those that are applicable and complete.
CHANGELOG