From 56155c29d500a1cc94b53b74dd458ec19a1a4e7c Mon Sep 17 00:00:00 2001
From: Victor Nova <lost@losttech.software>
Date: Mon, 8 Aug 2022 12:39:05 -0700
Subject: [PATCH] BREAKING: disabled implicit conversion from Python objects
 implementing sequence protocol to .NET arrays when the target .NET type is
 `System.Object`. The conversion is still attempted when the target type is a
 `System.Array`

fixes https://github.com/pythonnet/pythonnet/issues/1900
---
 CHANGELOG.md             | 3 +++
 src/runtime/Converter.cs | 5 -----
 tests/test_conversion.py | 7 +++++++
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9b5dd1816..9f0f212e6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -67,6 +67,9 @@ or the DLL must be loaded in advance. This must be done before calling any other
 -   BREAKING: disabled implicit conversion from C# enums to Python `int` and back.
 One must now either use enum members (e.g. `MyEnum.Option`), or use enum constructor
 (e.g. `MyEnum(42)` or `MyEnum(42, True)` when `MyEnum` does not have a member with value 42).
+-   BREAKING: disabled implicit conversion from Python objects implementing sequence protocol to
+.NET arrays when the target .NET type is `System.Object`. The conversion is still attempted when the
+target type is a `System.Array`.
 -   Sign Runtime DLL with a strong name
 -   Implement loading through `clr_loader` instead of the included `ClrModule`, enables
     support for .NET Core
diff --git a/src/runtime/Converter.cs b/src/runtime/Converter.cs
index e1820f05b..2e0edc3b5 100644
--- a/src/runtime/Converter.cs
+++ b/src/runtime/Converter.cs
@@ -389,11 +389,6 @@ internal static bool ToManagedValue(BorrowedReference value, Type obType,
                     return true;
                 }
 
-                if (Runtime.PySequence_Check(value))
-                {
-                    return ToArray(value, typeof(object[]), out result, setError);
-                }
-
                 result = new PyObject(value);
                 return true;
             }
diff --git a/tests/test_conversion.py b/tests/test_conversion.py
index a5b4c6fd9..f8d8039c6 100644
--- a/tests/test_conversion.py
+++ b/tests/test_conversion.py
@@ -577,6 +577,13 @@ class Foo(object):
     ob.ObjectField = Foo
     assert ob.ObjectField == Foo
 
+    class PseudoSeq:
+        def __getitem__(self, idx):
+           return 0
+
+    ob.ObjectField = PseudoSeq()
+    assert ob.ObjectField.__class__.__name__ == "PseudoSeq"
+
 
 def test_null_conversion():
     """Test null conversion."""