Skip to content

Add __version__ #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add __version__ #1946

wants to merge 1 commit into from

Conversation

filmor
Copy link
Member

@filmor filmor commented Sep 17, 2022

Add __version__ property to pythonnet, trying first importlib.metadata, then pkg_resources, then version.txt before using "unknown".

Fixes #1909.

@amueller I'm still not sure whether this is needed in modern Python versions (we only support 3.7 upwards nowadays), but since you are also a Bonn Maths alumnus ... ;)

@filmor filmor changed the base branch from master to release September 17, 2022 15:43
@amueller
Copy link

I am! How did you know? But I don't think that's a good enough reason to add unnecessary complexity to your code! Sorry I was unaware that importlib.metadata does that now.

@filmor filmor deleted the branch pythonnet:release September 29, 2022 15:12
@filmor filmor closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants