Fix Pyobject GC Finalize & Enable NUnit Exit Code #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how `PythonDerivedType` finalizes. Closes pythonnet#364 Possibly related to pythonnet#245
Codecov Report@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 62.72% 62.72%
=======================================
Files 61 61
Lines 5253 5253
Branches 876 876
=======================================
Hits 3295 3295
Misses 1740 1740
Partials 218 218
Continue to review full report at Codecov.
|
tonyroberts
approved these changes
Feb 8, 2017
filmor
approved these changes
Feb 8, 2017
This was referenced Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes random crashes on AppVeyor Embedded tests.
Specifically, fixes crashes when exiting a program.
Does this close any currently open issues?
Closes #364
Closes #262
Maybe #245
Any other comments?
Enables NUNIT's exit code to be part of the success criteria of the tests.
No new tests added since it affected all tests 👍
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG