Skip to content

Fix PyObject.GetHashCode #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2018
Merged

Fix PyObject.GetHashCode #677

merged 2 commits into from
May 28, 2018

Conversation

GSPP
Copy link

@GSPP GSPP commented May 27, 2018

Fixes #676

@filmor
Copy link
Member

filmor commented May 27, 2018

Did you check that ulong's GetHashCode takes all bits into account? I can't find documentation on this, and apparently IntPtr.GetHashCode used to be broken in this regard.

@GSPP
Copy link
Author

GSPP commented May 28, 2018

I checked this with Reflector on .NET 4.7.2. Even if this is not working on lower versions, which I doubt for ulong, then the fix is still better than nothing. But it should be totally fine.

@filmor filmor merged commit 06ded7a into pythonnet:master May 28, 2018
@filmor
Copy link
Member

filmor commented May 28, 2018

Cool, thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GSPP @filmor