Skip to content

Commit 0a10364

Browse files
committed
Use the issue's Session object on issue.milestone
Without passing in "self" to the Milestone for the issue.milestone attribute, we were getting a completely brand-new GitHubSession. This meant that we were failing to use Betamax which caused our tests to be unreliable and to bypass Betamax while running the test-suite.
1 parent a15fcf1 commit 0a10364

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

github3/issues/issue.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def _update_attributes(self, issue):
8383
#: issue was assigned to.
8484
self.milestone = issue['milestone']
8585
if self.milestone:
86-
self.milestone = Milestone(self.milestone)
86+
self.milestone = Milestone(self.milestone, self)
8787

8888
#: Issue number (e.g. #15)
8989
self.number = issue['number']

0 commit comments

Comments
 (0)