Remove _class_attribute and missed _strptime_attribute

sigmavirus24 · sigmavirus24 · commit 10d9ac671efb · 2018-03-11T10:22:31.000-05:00
diff --git a/github3/gists/comment.py b/github3/gists/comment.py
@@ -64,9 +64,7 @@ def _update_attributes(self, comment):
         self.created_at = self._strptime(comment['created_at'])
         self.id = comment['id']
         self.updated_at = self._strptime(comment['updated_at'])
-        self.user = self._class_attribute(
-            comment, 'user', users.ShortUser, self,
-        )
+        self.user = users.ShortUser(comment['user'], self)
 
     def _repr(self):
         return '<Gist Comment [{0}]>'.format(self.user.login)
diff --git a/github3/models.py b/github3/models.py
@@ -94,25 +94,6 @@ def _get_attribute(cls, data, attribute, fallback=None):
             return fallback
         return result
 
-    @classmethod
-    def _class_attribute(cls, data, attribute, cl, *args, **kwargs):
-        """Return the attribute from the json data and instantiate the class.
-
-        :param dict data: dictionary used to put together the model or None
-        :param str attribute: key of the attribute
-        :param class cl: class that will be instantiated
-        :returns: instantiated class or None
-        :rtype: object or None
-        """
-        value = cls._get_attribute(data, attribute)
-        if value:
-            return cl(
-                value,
-                *args,
-                **kwargs
-            )
-        return value
-
     @classmethod
     def _strptime_attribute(cls, data, attribute):
         """Get a datetime object from a dict, return None if it wan't found.
diff --git a/github3/repos/release.py b/github3/repos/release.py
@@ -367,7 +367,7 @@ def _update_attributes(self, asset):
         self.name = asset['name']
         self.size = asset['size']
         self.state = asset['state']
-        self.updated_at = self._strptime_attribute(asset, 'updated_at')
+        self.updated_at = self._strptime(asset['updated_at'])
 
     def _repr(self):
         return '<Asset [{0}]>'.format(self.name)
