Merge pull request sigmavirus24#920 from tobiashenkel/default-read-timeout

sigmavirus24 · web-flow · commit d146cc947b01 · 2019-01-23T13:57:16.000-06:00
Increase default read timeout to 10 seconds
diff --git a/src/github3/session.py b/src/github3/session.py
@@ -93,7 +93,7 @@ class GitHubSession(requests.Session):
         "two_factor_auth_cb",
     ]
 
-    def __init__(self, default_connect_timeout=4, default_read_timeout=1):
+    def __init__(self, default_connect_timeout=4, default_read_timeout=10):
         """Slightly modify how we initialize our session."""
         super(GitHubSession, self).__init__()
         self.default_connect_timeout = default_connect_timeout
diff --git a/tests/unit/test_github_session.py b/tests/unit/test_github_session.py
@@ -40,7 +40,8 @@ def test_default_timeout(self, request_mock):
         r = s.get("http://example.com")
         assert r is response
         request_mock.assert_called_once_with(
-            "GET", "http://example.com", allow_redirects=True, timeout=(4, 1)
+            "GET", "http://example.com", allow_redirects=True,
+            timeout=(4, 10)
         )
 
     @mock.patch.object(requests.Session, "request")
@@ -148,7 +149,8 @@ def test_request_ignores_responses_that_do_not_require_2fa(
         r = s.get("http://example.com")
         assert r is response
         request_mock.assert_called_once_with(
-            "GET", "http://example.com", allow_redirects=True, timeout=(4, 1)
+            "GET", "http://example.com", allow_redirects=True,
+            timeout=(4, 10)
         )
 
     @mock.patch.object(requests.Session, "request")

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ class GitHubSession(requests.Session):`
`93`	`93`	`"two_factor_auth_cb",`
`94`	`94`	`]`
`95`	`95`
`96`		`- def __init__(self, default_connect_timeout=4, default_read_timeout=1):`
	`96`	`+ def __init__(self, default_connect_timeout=4, default_read_timeout=10):`
`97`	`97`	`"""Slightly modify how we initialize our session."""`
`98`	`98`	`super(GitHubSession, self).__init__()`
`99`	`99`	`self.default_connect_timeout = default_connect_timeout`