fix: Rename success tag to error

untitaker · untitaker · commit 6bee45063ac2 · 2019-06-11T18:16:37.000+02:00
diff --git a/sentry_sdk/hub.py b/sentry_sdk/hub.py
@@ -375,10 +375,10 @@ def span(self, span=None, **kwargs):
         try:
             yield span
         except Exception:
-            span.set_tag("success", False)
+            span.set_tag("error", True)
             raise
         else:
-            span.set_tag("success", True)
+            span.set_tag("error", False)
         finally:
             span.finish()
             self.finish_trace(span)
diff --git a/sentry_sdk/integrations/django/__init__.py b/sentry_sdk/integrations/django/__init__.py
@@ -368,8 +368,6 @@ def record_sql(sql, params, cursor=None):
         except Exception:
             pass
 
-    span = None
-
     if real_sql:
         hub.add_breadcrumb(message=real_sql, category="query")
         with hub.span(op="db.statement", description=real_sql):
