cmake: fix WITH_VTK usage

alalek · alalek · commit 22c0bb7dc957 · 2017-11-29T21:43:09.000+03:00
'WITH_' variables is intended to enable CMake scripts with some autodetection logic.
'WITH_' can be off, but components is really enabled via command-line options
with proper variables setup (including 'HAVE_').
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -656,7 +656,9 @@ if(WITH_MATLAB)
   include(cmake/OpenCVFindMatlab.cmake)
 endif()
 
-include(cmake/OpenCVDetectVTK.cmake)
+if(WITH_VTK)
+  include(cmake/OpenCVDetectVTK.cmake)
+endif()
 
 if(WITH_OPENVX)
   include(cmake/FindOpenVX.cmake)
diff --git a/cmake/OpenCVDetectVTK.cmake b/cmake/OpenCVDetectVTK.cmake
@@ -1,7 +1,3 @@
-if(NOT WITH_VTK)
-  return()
-endif()
-
 # VTK 6.x components
 find_package(VTK QUIET COMPONENTS vtkInteractionStyle vtkRenderingLOD vtkIOPLY vtkFiltersTexture vtkRenderingFreeType vtkIOExport NO_MODULE)
 IF(VTK_FOUND)
diff --git a/modules/viz/CMakeLists.txt b/modules/viz/CMakeLists.txt
@@ -1,4 +1,4 @@
-if(NOT WITH_VTK OR NOT DEFINED HAVE_VTK OR NOT HAVE_VTK)
+if(NOT HAVE_VTK)
   ocv_module_disable(viz)
 endif()
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-if(NOT WITH_VTK OR NOT DEFINED HAVE_VTK OR NOT HAVE_VTK)`
	`1`	`+if(NOT HAVE_VTK)`
`2`	`2`	`ocv_module_disable(viz)`
`3`	`3`	`endif()`
`4`	`4`