Fix redundant move

cyyever · cyyever · commit 03f9e453ae6a · 2025-01-29T11:21:36.000+08:00
diff --git a/torch/csrc/jit/tensorexpr/kernel.cpp b/torch/csrc/jit/tensorexpr/kernel.cpp
@@ -483,7 +483,7 @@ ExprHandle TensorExprKernel::getVarForShape(const c10::ShapeSymbol& ss) {
   if (it == shapeSymbolToVar_.end()) {
     VarHandle var("ss" + std::to_string(-value), kLong);
     shapeSymbolToVar_.emplace(value, var);
-    return std::move(var);
+    return var;
   }
   return it->second;
 }
@@ -1020,7 +1020,7 @@ ExprHandle TensorExprKernel::getStrideArg(
         kLong);
     strideArgToVar_[std::pair<size_t, size_t>(
         tensor_input_index, stride_index)] = var;
-    return std::move(var);
+    return var;
   }
   return it->second;
 }

Original file line number	Diff line number	Diff line change
`@@ -483,7 +483,7 @@ ExprHandle TensorExprKernel::getVarForShape(const c10::ShapeSymbol& ss) {`
`483`	`483`	`if (it == shapeSymbolToVar_.end()) {`
`484`	`484`	`VarHandle var("ss" + std::to_string(-value), kLong);`
`485`	`485`	`shapeSymbolToVar_.emplace(value, var);`
`486`		`- return std::move(var);`
	`486`	`+ return var;`
`487`	`487`	`}`
`488`	`488`	`return it->second;`
`489`	`489`	`}`
`@@ -1020,7 +1020,7 @@ ExprHandle TensorExprKernel::getStrideArg(`
`1020`	`1020`	`kLong);`
`1021`	`1021`	`strideArgToVar_[std::pair<size_t, size_t>(`
`1022`	`1022`	`tensor_input_index, stride_index)] = var;`
`1023`		`- return std::move(var);`
	`1023`	`+ return var;`
`1024`	`1024`	`}`
`1025`	`1025`	`return it->second;`
`1026`	`1026`	`}`