-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Open
Labels
module: correctness (silent)issue that returns an incorrect result silentlyissue that returns an incorrect result silentlymodule: macosMac OS related issuesMac OS related issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🐛 Describe the bug
I've noticed that running the test on M4 results in failure
======================================================================
FAIL: test_linalg_cholesky (__main__.TestMPS.test_linalg_cholesky)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/malfet/py3.12-nightly/lib/python3.12/site-packages/torch/testing/_internal/common_utils.py", line 3154, in wrapper
method(*args, **kwargs)
File "/Users/malfet/git/pytorch/pytorch/test/test_mps.py", line 5747, in test_linalg_cholesky
run_cholesky_test(size, batch_size, upper=upper)
File "/Users/malfet/git/pytorch/pytorch/test/test_mps.py", line 5737, in run_cholesky_test
self.assertEqual(output_cpu, output_mps, atol=2e-5, rtol=1e-6)
File "/Users/malfet/py3.12-nightly/lib/python3.12/site-packages/torch/testing/_internal/common_utils.py", line 4102, in assertEqual
raise error_metas.pop()[0].to_error( # type: ignore[index]
AssertionError: Tensor-likes are not close!
Mismatched elements: 480 / 16384 (2.9%)
Greatest absolute difference: 1552.90283203125 at index (0, 95, 81) (up to 2e-05 allowed)
Greatest relative difference: inf at index (0, 1, 0) (up to 1e-06 allowed)
The failure occurred for item [0]
To execute this test, run the following from the base repo dir:
python test/test_mps.py TestMPS.test_linalg_cholesky
This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
----------------------------------------------------------------------
Ran 17 tests in 0.516s
FAILED (failures=1, expected failures=9)
While running the same build and the same test on M2 succeeds...
Versions
nightly
Metadata
Metadata
Assignees
Labels
module: correctness (silent)issue that returns an incorrect result silentlyissue that returns an incorrect result silentlymodule: macosMac OS related issuesMac OS related issuestriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module