Hook up bf16_gemv_trans to x86 bf16 GEMM #139220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/139220
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 81ba770 with merge base 419a7e1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 29, 2024
Closed
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This was referenced Oct 29, 2024
swolchok
added a commit
that referenced
this pull request
Oct 29, 2024
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) ghstack-source-id: 250775158 Pull Request resolved: #139220
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 3, 2024
Pull Request resolved: #139220 This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . ghstack-source-id: 251589338 Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. @exported-using-ghexport Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/)
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D65170967 |
swolchok
added a commit
that referenced
this pull request
Nov 4, 2024
Pull Request resolved: #139220 This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . ghstack-source-id: 251716245 Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. @exported-using-ghexport Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/)
malfet
approved these changes
Nov 8, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pobin6
pushed a commit
to pobin6/pytorch
that referenced
this pull request
Dec 5, 2024
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 . Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2. Differential Revision: [D65170967](https://our.internmc.facebook.com/intern/diff/D65170967/) Pull Request resolved: pytorch#139220 Approved by: https://github.com/malfet ghstack dependencies: pytorch#139084, pytorch#139090, pytorch#139558, pytorch#139081, pytorch#139208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is the big milestone for bf16 and should enable us to close pytorch/torchchat#1253 .
Testing: ran python torchchat.py generate llama3.2-1b --dtype bf16 --device cpu on x86 machine with AVX512-bf16. observed similar tokens/sec with and without MKL path hand-disabled. Also observed speedup from ~2.1 tok/sec to 7.4 tok/sec on x86 machine with only AVX2.
Differential Revision: D65170967