Package dependency on testthat seems to be incorrect #151

New issue

Jump to bottom

Closed

atheriel opened this issue Mar 12, 2021 · 1 comment

atheriel commented Mar 12, 2021

The testthat package is listed as Suggests, but load_all() calls library(testthat):

> pkgload::load_all()
ℹ Loading <my-package>
Error in ("base" %:::% "library")("testthat", warn.conflicts = FALSE) : 
  there is no package called ‘testthat’
> traceback()
3: stop(packageNotFoundError(package, lib.loc, sys.call()))
2: ("base" %:::% "library")("testthat", warn.conflicts = FALSE)
1: pkgload::load_all()

To reproduce:

Uninstall testthat.
Run pkgload::load_all() on any package.

I think this could be fixed by checking if testthat is present beforehand.

The text was updated successfully, but these errors were encountered:

Member

jimhester commented Mar 12, 2021

A workaround is to call load_all with attach_testthat = FALSE.

However we could probably add a test to uses_testthat() to handle this case as well.

jimhester closed this as completed in

dece602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment