Put RTools on the path when necessary

jimhester · jimhester · commit 5a33ee51824d · 2018-09-13T16:48:35.000-04:00
This avoids users needing to manually add the RTools location to their
PATH; which is error prone as you then have to update it for newer
RTools versions and ensure the unix tools bundled with RTools don't
conflict with other tools on your PATH.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -26,12 +26,14 @@ Suggests:
     covr,
     git2r (>= 0.23.0),
     mockery,
-    pkgbuild,
+    pkgbuild (>= 1.0.0.9000),
     pingr,
     testthat,
     withr
 Depends:
     R (>= 3.0.0)
+Remotes:
+    r-lib/pkgbuild
 RoxygenNote: 6.1.0
 SystemRequirements: Subversion for install_svn, git for install_git
 Encoding: UTF-8
diff --git a/NEWS.md b/NEWS.md
@@ -8,6 +8,9 @@
 
 # Development
 
+* `install_()*` functions now temporally put Rtools on the PATH when necessary,
+  as long as the pkgbuild package is installed.
+
 * `standardise_dep()` exported, for use in devtools.
 
 * Remotes can be forced to use only its internal code by setting the
diff --git a/R/install.R b/R/install.R
@@ -1,8 +1,12 @@
 install <- function(pkgdir, dependencies, quiet, build, build_opts, upgrade,
                     repos, type, ...) {
 
-  if (file.exists(file.path(pkgdir, "src")) && ! has_devel()) {
-    missing_devel_warning(pkgdir)
+  if (file.exists(file.path(pkgdir, "src"))) {
+    if (has_package("pkgbuild")) {
+      pkgbuild::local_build_tools(required = TRUE)
+    } else if (!has_devel()) {
+      missing_devel_warning(pkgdir)
+    }
   }
 
   ## Check for circular dependencies. We need to know about the root
