Skip to content

Commit 5b3da5f

Browse files
Neil-Schneiderjimhester
authored andcommitted
Pass ellipsis parameters when install dependencies (#444)
* Pass ellipsis to install_deps Do this because the unnamed options were not being passed all the way through the install chain. * Update News.md with notes on `install()` change Do this because it is important to communicate changes. * Results of makefile
1 parent 2f1a040 commit 5b3da5f

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

NEWS.md

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* `install_gitlab()` now installs from repositories in subgroups and with dots
44
in their name. `subdir` is now an explicit argument instead of implicit in
55
`repo` (@robertdj, #259, #420).
6+
* `install()` now passes the ellipsis `...` to `install_deps()` (@Neil-Schneider, #411)
67

78
# remotes 2.1.0
89

R/install.R

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ install <- function(pkgdir, dependencies, quiet, build, build_opts, build_manual
2323
install_deps(pkgdir, dependencies = dependencies, quiet = quiet,
2424
build = build, build_opts = build_opts, build_manual = build_manual,
2525
build_vignettes = build_vignettes, upgrade = upgrade, repos = repos,
26-
type = type)
26+
type = type, ...)
2727

2828
if (isTRUE(build)) {
2929
dir <- tempfile()

inst/install-github.R

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

install-github.R

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)