Long path help msg in non-en locales

gaborcsardi · gaborcsardi · commit 9b5f7a730219 · 2018-10-03T03:40:52.000-07:00
The error string is different in this case. Improves #84.
diff --git a/R/install.R b/R/install.R
@@ -115,7 +115,8 @@ safe_build_package <- function(pkgdir, build_opts, dest_path, quiet, use_pkgbuil
 
 msg_for_long_paths <- function(output) {
   if (sys_type() == "windows" &&
-      any(grepl("over-long path length", output$stderr))) {
+      (r_error_matches("over-long path", output$stderr) ||
+       r_error_matches("over-long path length", output$stderr))) {
     message(
       "\nIt seems that this package contains files with very long paths.\n",
       "This is not supported on most Windows versions. Please contact the\n",
@@ -124,6 +125,11 @@ msg_for_long_paths <- function(output) {
   }
 }
 
+r_error_matches <- function(msg, str) {
+  any(grepl(msg, str)) ||
+    any(grepl(gettext(msg, domain = "R"), str))
+}
+
 #' Install package dependencies if needed.
 #'
 #' @inheritParams package_deps
