teach remotes about the 'standard' remote type

kevinushey · jimhester · commit bc902816f731 · 2019-03-29T11:38:05.000-04:00
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,9 @@
 
 # remotes dev
 
+* remotes now understands the "standard" remote type, as produced by packages
+  installed from CRAN using `pak` (#309)
+
 * Fix return type of `install_remote()` when there is a circular dependency (#225)
 
 * `remote_package_name.github_remote()` now works properly on Windows (#248)
diff --git a/R/install-remote.R b/R/install-remote.R
@@ -166,6 +166,11 @@ package2remote <- function(name, lib = .libPaths(), repos = getOption("repos"),
   }
 
   switch(x$RemoteType,
+    standard = remote("cran",
+      name = x$Package,
+      repos = x$RemoteRepos,
+      pkg_type = x$RemotePkgType,
+      sha = x$RemoteSha),
     github = remote("github",
       host = x$RemoteHost,
       package = x$RemotePackage,
@@ -231,7 +236,8 @@ package2remote <- function(name, lib = .libPaths(), repos = getOption("repos"),
       repo = x$RemoteRepo,
       release = x$RemoteRelease,
       sha = x$RemoteSha,
-      branch = x$RemoteBranch)
+      branch = x$RemoteBranch),
+    stop(sprintf("can't convert package with RemoteType '%s' to remote", x$RemoteType))
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,11 @@ package2remote <- function(name, lib = .libPaths(), repos = getOption("repos"),`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`switch(x$RemoteType,`
	`169`	`+ standard = remote("cran",`
	`170`	`+ name = x$Package,`
	`171`	`+ repos = x$RemoteRepos,`
	`172`	`+ pkg_type = x$RemotePkgType,`
	`173`	`+ sha = x$RemoteSha),`
`169`	`174`	`github = remote("github",`
`170`	`175`	`host = x$RemoteHost,`
`171`	`176`	`package = x$RemotePackage,`
`@@ -231,7 +236,8 @@ package2remote <- function(name, lib = .libPaths(), repos = getOption("repos"),`
`231`	`236`	`repo = x$RemoteRepo,`
`232`	`237`	`release = x$RemoteRelease,`
`233`	`238`	`sha = x$RemoteSha,`
`234`		`- branch = x$RemoteBranch)`
	`239`	`+ branch = x$RemoteBranch),`
	`240`	`+ stop(sprintf("can't convert package with RemoteType '%s' to remote", x$RemoteType))`
`235`	`241`	`)`
`236`	`242`	`}`
`237`	`243`