Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rack/rack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.7
Choose a base ref
...
head repository: rack/rack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.2.8
Choose a head ref
  • 7 commits
  • 8 files changed
  • 6 contributors

Commits on Apr 25, 2023

  1. Configuration menu
    Copy the full SHA
    c4245c5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    e7f4869 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Update cookie.rb (#2092)

    Backports commit 9cad48e to version 2.2
    dchandekstark authored Jul 15, 2023
    Configuration menu
    Copy the full SHA
    287fe43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fdcf1f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Fix inefficient assert pattern in Rack::Lint (#2101)

    Partial backport of 1970771
    
    Differences from original commit:
    - `#assert` is not deprecated
    - `include Assertion` is not removed
    - The assertion in `check_status` is the 2-2-stable version since the
      SPEC [change][1] to require statuses to be integers was merged before
      this
    - `#dump` was added to the `REQUEST_METHOD` assertion [after][2] the
      original commit, so it was added here as well
    
    This fixes an issue encountered when adding `Rack::Lint` to the Rails
    test suite. Rails puts a lazily evaluated class inside the request env
    that has the potential to raise when converted to a string. Since this
    assertion in `Rack::Lint` calls `#inspect` on `env` whether or not `env`
    is a `Hash`, the lazily evaluated class would raise at that point and
    prevent the rest of `Rack::Lint` from validating the conformity of the
    request.
    
    By backporting this change, `#inspect` is now only called when the
    `LintError` would be raised which avoids the problem.
    
    [1]: ba25ade
    [2]: b426cc2
    
    Co-authored-by: Benoit Daloze <eregontp@gmail.com>
    skipkayhil and eregon authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    cee73b3 View commit details
    Browse the repository at this point in the history
  2. Regenerate SPEC (#2102)

    It looks like this has been out of sync since additional assertions were
    [added][1] to `Rack::Lint` concerning `SERVER_PORT`, `SERVER_NAME`, and
    `HTTP_HOST`.
    
    [1]: 290523f
    skipkayhil authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0a46487 View commit details
    Browse the repository at this point in the history
  3. Bump patch version.

    ioquatix committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f169ff7 View commit details
    Browse the repository at this point in the history
Loading