-
Notifications
You must be signed in to change notification settings - Fork 526
fix(c): remove redundant newline and fix $0
position in main
snippents
#451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revert commit 7a57697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but perhaps we can bring in some others so we're all on the same page since it's reverting some changes.
Will wait to merge, so others can view them as well.
Assuming there isn't any push back between now and the end of the week, I'll merge this PR then. |
The |
Hi @REmerald, see the comment above. It might be the case we can decline this PR for now 🤔 |
@OkelleyDevelopment Other snippets with braces (if, switch, for, while, functions, struct) has been following this style for 1.5 years and everybody has been ok with it. Nobody changed them through pull requests, even @ilan-schemoul changed only these 2 and didn't touch other mentioned above. So,
is not a valid argument, also for reasons explained in pr description.
Any logic behind this? Plus, many people use format-on-save and clang-format will remove it anyways if you don't have any code between the brace and the newline. |
I don't see the need for empty main but sure we can revert to be consistent |
It's for organizational purposes, the user may decide to write some functions before
@OkelleyDevelopment surmish put the thumbs-up emoji, so everybody seems to agree. Can it be merged now? |
I really don't agree we should do everything according to a fringe case. |
Thanks everyone for your input! I will merge this PR for the consistency as the repo stands. Going forward, perhaps we should apply a higher level of scrutiny regarding the structure of snippets being added/modified to avoid similar discrepancies from reoccurring 🤔 |
Kind of reverts 7a57697 and #443
The main point of not putting
$0
on newly indented line is because it's way easier for a user to press enter than pressingesc
thendd
if insertingif
with empty{}
was intended. See #237 (comment).