feat(python): change order of navigation in comprehension snippets #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is motivated by getting better completions when using a language server. When starting from the `iterable` part of the snippet, the language server can infer the type of the values contained in the iterable, so that when we get to the part of writing the `value` it can offer autocompletion and suggestions for fields and methods of `value`.
OkelleyDevelopment
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by getting better completions when using a language server. When starting from the
iterablepart of the snippet, the language server can infer the type of the values contained in the iterable, so that when we get to the part of writing thevalueit can offer autocompletion and suggestions for fields and methods ofvalue.