Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:time option for #touch #18905

Closed
jeremy opened this issue Feb 11, 2015 · 4 comments
Closed

:time option for #touch #18905

jeremy opened this issue Feb 11, 2015 · 4 comments
Labels
openacademy
Milestone
5.0.0

Comments

@jeremy
Copy link
Member

jeremy commented Feb 11, 2015

#touch always uses the current time. If we want to touch with a different time, we have to do it ourselves. That makes it awkward to touch a record to match another record, to touch a record with current transaction time, to touch with an associated file's mtime, or to touch with a previous time reflecting an earlier occurrence.

We can take an optional time: argument that defaults to current_time_from_proper_timezone to make these cases possible.
@jeremy jeremy added this to the 5.0.0 milestone Feb 11, 2015
@jeremy jeremy mentioned this issue Feb 11, 2015
Closed
@andyatkinson
Copy link
Member

@jeremy Does #18824 fix the issue? If not, is this something I could look at? I see there is an openacademy tag and I don't know whether that means it has been claimed. I don't see a specific assignee. Thanks.

@kaspth
Copy link
Contributor

kaspth commented Feb 13, 2015

@andyatkinson A number of our Core Team members and Committers are mentoring students for Facebook's Open Academy and giving them tasks to work. Your interest is appreciated, but we have reserved the rights for the students (even if anyone in particular hasn't been picked yet).

Also @jeremy's comment here explains the relationship between these two issues. I hope you won't be deterred 💛

@andyatkinson
Copy link
Member

@kaspth I'm an aspiring Rails contributor. If you see an issue that you think is not appropriate for the Open Academy group, please ping me about it, I'd like to take a look. Thanks!

@hjoo
Copy link
Contributor

hjoo commented Feb 16, 2015

Hi, I'm working on this issue and am wondering if there's a clean way to have optional arguments in ruby?

@hjoo hjoo mentioned this issue Feb 16, 2015
Merged
@rafaelfranca rafaelfranca modified the milestones: 5.0.0 [temp], 5.0.0 Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
openacademy
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
5 participants
@jeremy @rafaelfranca @kaspth @andyatkinson @hjoo