Skip to content

NpmSpec Comparison Between Prerelease Versions is Wrong #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arjunaskykok opened this issue Jun 12, 2020 · 7 comments
Open

NpmSpec Comparison Between Prerelease Versions is Wrong #100

arjunaskykok opened this issue Jun 12, 2020 · 7 comments
Labels
Topic:NPM Implementing NPM-style version specifiers Type:Bug

Comments

@arjunaskykok
Copy link

arjunaskykok commented Jun 12, 2020 •
edited
Loading

Version is 2.8.5.

>>> from semantic_version import NpmSpec, Version
>>> NpmSpec("<0.1.1-alpha.1").match(Version("0.1.1-beta.1"))
True
>>> NpmSpec("<0.1.1-alpha.1").match(Version("0.1.1-rc.1"))
True
>>> NpmSpec("<0.1.1-beta.7").match(Version("0.1.1-beta.8"))
True

They should be false.
@arjunaskykok arjunaskykok changed the title NpmSpec Comparison Involving Alpha Version is Wrong NpmSpec Comparison Between Prerelease Versions is Wrong Jun 12, 2020
@arjunaskykok arjunaskykok mentioned this issue Jun 13, 2020
Open
@rbarrois
Copy link
Owner

This looks indeed like a bug; I don't understand why the current tests fail to detect it :/

@rbarrois rbarrois added Topic:NPM Implementing NPM-style version specifiers Type:Bug labels Jun 15, 2020
@arjunaskykok
Copy link
Author

Because you only test '>1.2.3-alpha.3' and '>=1.2.3-alpha.3' cases (GT and GTE). No cases for prerelease versions with LT and LTE. :)

@smiller171
Copy link

possibly related:

>>> NpmSpec(">=2.0.1-").match(Version("2.0.1-rc1"))
False
>>> NpmSpec(">=2.0.1-0").match(Version("2.0.1-rc1"))
True

I believe >=2.0.1- should match all 2.0.1 prerelease versions of 2.0.1, but in actuality you need to add some character after the -

@smiller171
Copy link

oh and the same issue with ~2.0.1- not matching anything

@tysonliddell
Copy link

tysonliddell commented Dec 15, 2022 •
edited
Loading

Here's another example that doesn't seem correct.

>>> from semantic_version import NpmSpec, Version
>>> NpmSpec("5.4.0-alpha.0").match(Version("5.4.0-alpha.0"))
True
>>> NpmSpec("5.4.0-alpha.0").match(Version("5.4.0"))
True  # this should be False

The same examples in semver from npm have the correct logic:

> var semver = require('semver');
> semver.satisfies('2.0.0-next.1', '2.0.0-next.1');
true
> semver.satisfies('2.0.0', '2.0.0-next.1');
false

@SpecialK118
Copy link

Any news about this?
I also encountered it (with jquery-ui that selected the beta version instead of latest stable).

> NpmSpec('<1.14.0').select([Version('1.13.3'), Version('1.14.0-beta.1')])
Version('1.14.0-beta.1')

@ugomancz
Copy link

ugomancz commented Feb 13, 2025 •
edited
Loading

Hi, any news about this? There are many cases in which the behavior differs from the node-semver package which I believe is a bug.

This test checks that the behavior is consistent with the node-semver implementation:

import pytest
from semantic_version import NpmSpec, Version


@pytest.mark.parametrize(
    "version, spec, satisfies",
    [
        ("1.0.0", "1.0.0", True),
        ("2.0.0", "1.0.0", False),
        ("1.0.0", "2.0.0", False),
        ("1.2.0", "<1.5.0 >1.0.0 || >1.5.0 <2.0.0", True),
        ("2.0.0", "<1.5.0 >1.0.0 || >1.5.0 <2.0.0", False),
        ("1.5.0", "<1.5.0 >1.0.0 || >1.5.0 <2.0.0", False),
        ("1.0.0-100", "1.0.0-100", True),
        ("1.0.0-200", "1.0.0-100", False),
        ("1.0.0", "1.0.0-100", False), # differs from node-semver
        ("1.0.0+100", "1.0.0+100", True),
        ("1.0.0+200", "1.0.0+100", True), # differs from node-semver
        ("1.0.0", "1.0.0+100", True), # differs from node-semver
        ("1.0.0-100", "<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200", True), # differs from node-semver
        ("1.0.0-199", "<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200", True), # differs from node-semver
        ("1.0.0-200", "<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200", False),
        ("1.0.0-150", "<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200", False),
        ("1.0.0+100", "<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200", False),
        ("1.0.0+199", "<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200", False),
        ("1.0.0+200", "<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200", False),
        ("1.0.0+150", "<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200", False),
    ],
)
def test_npm_spec(version: str, spec: str, satisfies: bool) -> None:
    if satisfies:
        assert Version(version) in NpmSpec(spec)
    else:
        assert Version(version) not in NpmSpec(spec)

Output from node-semver:

root@fa57241627c4:/temp# npm list
temp@ /temp
`-- semver@7.7.1

> s.satisfies("1.0.0","1.0.0")
true
> s.satisfies("2.0.0","1.0.0")
false
> s.satisfies("1.0.0","2.0.0")
false
> s.satisfies("1.2.0","<1.5.0 >1.0.0 || >1.5.0 <2.0.0")
true
> s.satisfies("2.0.0","<1.5.0 >1.0.0 || >1.5.0 <2.0.0")
false
> s.satisfies("1.5.0","<1.5.0 >1.0.0 || >1.5.0 <2.0.0")
false
> s.satisfies("1.0.0-100","1.0.0-100")
true
> s.satisfies("1.0.0-200","1.0.0-100")
false
> s.satisfies("1.0.0","1.0.0-100")
false
> s.satisfies("1.0.0+100","1.0.0+100")
true
> s.satisfies("1.0.0+200","1.0.0+100")
true
> s.satisfies("1.0.0","1.0.0+100")
true
> s.satisfies("1.0.0-100","<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200")
true
> s.satisfies("1.0.0-199","<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200")
true
> s.satisfies("1.0.0-200","<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200")
false
> s.satisfies("1.0.0-150","<1.0.0-150 >=1.0.0-100 || >1.0.0-150 <1.0.0-200")
false
> s.satisfies("1.0.0+100","<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200")
false
> s.satisfies("1.0.0+199","<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200")
false
> s.satisfies("1.0.0+200","<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200")
false
> s.satisfies("1.0.0+150","<1.0.0+150 >=1.0.0+100 || >1.0.0+150 <1.0.0+200")
false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Topic:NPM Implementing NPM-style version specifiers Type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rbarrois @smiller171 @SpecialK118 @tysonliddell @arjunaskykok @ugomancz