Skip to content

Commit 3516f99

Browse files
iclantoniclanton
authored
Merge pull request microsoft#2901 from MichaelDeBoey/update-node-types
chore: update `@types/node` version to v12
2 parents fac5559 + 61653fd commit 3516f99

File tree

98 files changed

+1435
-1041
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

98 files changed

+1435
-1041
lines changed

‎apps/api-documenter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"@rushstack/heft-node-rig": "workspace:*",
3232
"@types/heft-jest": "1.0.1",
3333
"@types/js-yaml": "3.12.1",
34-
"@types/node": "10.17.13",
34+
"@types/node": "12.20.24",
3535
"@types/resolve": "1.17.1",
3636
"jest": "~25.4.0"
3737
}

‎apps/api-extractor-model/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@
2323
"@rushstack/heft": "0.38.1",
2424
"@rushstack/heft-node-rig": "1.2.13",
2525
"@types/heft-jest": "1.0.1",
26-
"@types/node": "10.17.13"
26+
"@types/node": "12.20.24"
2727
}
2828
}

‎apps/api-extractor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"@rushstack/heft-node-rig": "1.2.13",
5454
"@types/heft-jest": "1.0.1",
5555
"@types/lodash": "4.14.116",
56-
"@types/node": "10.17.13",
56+
"@types/node": "12.20.24",
5757
"@types/resolve": "1.17.1",
5858
"@types/semver": "7.3.5"
5959
}

‎apps/heft/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"@types/eslint": "7.2.0",
5757
"@types/glob": "7.1.1",
5858
"@types/heft-jest": "1.0.1",
59-
"@types/node": "10.17.13",
59+
"@types/node": "12.20.24",
6060
"@types/semver": "7.3.5",
6161
"colors": "~1.2.1",
6262
"tslint": "~5.20.1",

‎apps/heft/src/utilities/subprocess/SubprocessTerminator.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@ import { Executable } from '@rushstack/node-core-library';
55
import * as child_process from 'child_process';
66
import process from 'process';
77

8-
declare module 'child_process' {
9-
/* eslint-disable */
10-
interface ChildProcess {
11-
exitCode?: number | null;
12-
}
13-
/* eslint-enable */
14-
}
15-
168
/**
179
* Details about how the `child_process.ChildProcess` was created.
1810
*/

‎apps/rundown/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@
2828
"@rushstack/heft": "workspace:*",
2929
"@rushstack/heft-node-rig": "workspace:*",
3030
"@types/heft-jest": "1.0.1",
31-
"@types/node": "10.17.13"
31+
"@types/node": "12.20.24"
3232
}
3333
}

‎apps/rush-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"@types/js-yaml": "3.12.1",
6666
"@types/lodash": "4.14.116",
6767
"@types/minimatch": "2.0.29",
68-
"@types/node": "10.17.13",
68+
"@types/node": "12.20.24",
6969
"@types/node-fetch": "1.6.9",
7070
"@types/npm-package-arg": "6.1.0",
7171
"@types/npm-packlist": "~1.1.1",

‎apps/rush-lib/src/cli/scriptActions/BaseScriptAction.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,9 @@ export abstract class BaseScriptAction extends BaseRushAction {
8080
break;
8181
default:
8282
throw new Error(
83-
`${RushConstants.commandLineFilename} defines a parameter "${(parameterJson as ParameterJson).longName}"` +
84-
` using an unsupported parameter kind "${(parameterJson as ParameterJson).parameterKind}"`
83+
`${RushConstants.commandLineFilename} defines a parameter "${
84+
(parameterJson as ParameterJson).longName
85+
}" using an unsupported parameter kind "${(parameterJson as ParameterJson).parameterKind}"`
8586
);
8687
}
8788

‎apps/rush-lib/src/logic/base/BaseInstallManager.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,9 @@ export abstract class BaseInstallManager {
383383
);
384384
} catch (ex) {
385385
console.log();
386-
console.log(`Unable to load the ${this._rushConfiguration.shrinkwrapFilePhrase}: ${(ex as Error).message}`);
386+
console.log(
387+
`Unable to load the ${this._rushConfiguration.shrinkwrapFilePhrase}: ${(ex as Error).message}`
388+
);
387389

388390
if (!this.options.allowShrinkwrapUpdates) {
389391
console.log();

‎apps/rush-lib/src/logic/buildCache/AzureStorageBuildCacheProvider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ interface IBlobError extends Error {
5050
status: string;
5151
parsedHeaders?: {
5252
errorCode: string;
53-
}
54-
}
53+
};
54+
};
5555
}
5656

5757
export class AzureStorageBuildCacheProvider extends CloudBuildCacheProviderBase {

‎apps/rush-lib/src/logic/buildCache/ProjectBuildCache.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// See LICENSE in the project root for license information.
33

44
import * as path from 'path';
5-
import * as events from 'events';
5+
import events from 'events';
66
import * as crypto from 'crypto';
77
import type * as stream from 'stream';
88
import * as tar from 'tar';

‎apps/rush-lib/src/logic/deploy/DeployManager.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,10 @@ export class DeployManager {
205205
try {
206206
this._traceResolveDependency(dependencyPackageName, packageJsonRealFolderPath, deployState);
207207
} catch (resolveErr) {
208-
if ((resolveErr as NodeJS.ErrnoException).code === 'MODULE_NOT_FOUND' && optionalDependencyNames.has(dependencyPackageName)) {
208+
if (
209+
(resolveErr as NodeJS.ErrnoException).code === 'MODULE_NOT_FOUND' &&
210+
optionalDependencyNames.has(dependencyPackageName)
211+
) {
209212
// Ignore missing optional dependency
210213
continue;
211214
}

‎apps/rush-lib/src/logic/npm/NpmShrinkwrapFile.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ export class NpmShrinkwrapFile extends BaseShrinkwrapFile {
6363

6464
return new NpmShrinkwrapFile(JSON.parse(data));
6565
} catch (error) {
66-
throw new Error(`Error reading "${shrinkwrapJsonFilename}":` + os.EOL + ` ${(error as Error).message}`);
66+
throw new Error(
67+
`Error reading "${shrinkwrapJsonFilename}":` + os.EOL + ` ${(error as Error).message}`
68+
);
6769
}
6870
}
6971

‎apps/rush-lib/src/utilities/TarExecutable.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import * as path from 'path';
55
import { Executable, FileSystem, FileWriter, Terminal } from '@rushstack/node-core-library';
66
import { ChildProcess } from 'child_process';
7-
import * as events from 'events';
7+
import events from 'events';
88

99
import { RushConfigurationProject } from '../api/RushConfigurationProject';
1010
import { EnvironmentConfiguration } from '../api/EnvironmentConfiguration';
@@ -151,8 +151,8 @@ export class TarExecutable {
151151
currentWorkingDirectory: currentWorkingDirectory
152152
});
153153

154-
childProcess.stdout.on('data', (chunk) => fileWriter.write(`[stdout] ${chunk}`));
155-
childProcess.stderr.on('data', (chunk) => fileWriter.write(`[stderr] ${chunk}`));
154+
childProcess.stdout?.on('data', (chunk) => fileWriter.write(`[stdout] ${chunk}`));
155+
childProcess.stderr?.on('data', (chunk) => fileWriter.write(`[stderr] ${chunk}`));
156156

157157
const [tarExitCode] = await events.once(childProcess, 'exit');
158158

‎apps/rush/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"@rushstack/heft": "workspace:*",
4242
"@rushstack/heft-node-rig": "workspace:*",
4343
"@types/heft-jest": "1.0.1",
44-
"@types/node": "10.17.13",
44+
"@types/node": "12.20.24",
4545
"@types/semver": "7.3.5"
4646
}
4747
}

‎build-tests-samples/heft-node-basic-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@rushstack/heft": "workspace:*",
1414
"@rushstack/heft-jest-plugin": "workspace:*",
1515
"@types/heft-jest": "1.0.1",
16-
"@types/node": "10.17.13",
16+
"@types/node": "12.20.24",
1717
"eslint": "~7.30.0",
1818
"typescript": "~4.4.2"
1919
}

‎build-tests-samples/heft-node-jest-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"@rushstack/heft": "workspace:*",
1313
"@rushstack/heft-jest-plugin": "workspace:*",
1414
"@types/heft-jest": "1.0.1",
15-
"@types/node": "10.17.13",
15+
"@types/node": "12.20.24",
1616
"eslint": "~7.30.0",
1717
"typescript": "~4.4.2"
1818
}

‎build-tests-samples/heft-node-rig-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
"@rushstack/heft": "workspace:*",
1414
"@rushstack/heft-node-rig": "workspace:*",
1515
"@types/heft-jest": "1.0.1",
16-
"@types/node": "10.17.13"
16+
"@types/node": "12.20.24"
1717
}
1818
}

‎build-tests-samples/packlets-tutorial/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"devDependencies": {
1212
"@rushstack/eslint-config": "workspace:*",
1313
"@rushstack/heft": "workspace:*",
14-
"@types/node": "10.17.13",
14+
"@types/node": "12.20.24",
1515
"eslint": "~7.30.0",
1616
"typescript": "~4.4.2"
1717
}

‎build-tests/api-documenter-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"@microsoft/api-documenter": "workspace:*",
1313
"@microsoft/api-extractor": "workspace:*",
1414
"@types/jest": "25.2.1",
15-
"@types/node": "10.17.13",
15+
"@types/node": "12.20.24",
1616
"fs-extra": "~7.0.1",
1717
"typescript": "~4.4.2"
1818
}

‎build-tests/api-extractor-lib1-test/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
},
1111
"devDependencies": {
1212
"@microsoft/api-extractor": "workspace:*",
13-
"@types/node": "10.17.13",
1413
"fs-extra": "~7.0.1",
1514
"typescript": "~2.9.2"
1615
}

‎build-tests/api-extractor-lib1-test/tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
"sourceMap": true,
88
"experimentalDecorators": true,
99
"strictNullChecks": true,
10-
"types": ["node"],
1110
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
1211
"outDir": "lib"
1312
},
14-
"include": ["src/**/*.ts", "typings/tsd.d.ts"]
13+
"include": ["src/**/*.ts"]
1514
}

‎build-tests/api-extractor-lib2-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"devDependencies": {
1212
"@microsoft/api-extractor": "workspace:*",
1313
"@types/jest": "25.2.1",
14-
"@types/node": "10.17.13",
14+
"@types/node": "12.20.24",
1515
"fs-extra": "~7.0.1",
1616
"typescript": "~4.4.2"
1717
}

‎build-tests/api-extractor-lib3-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"devDependencies": {
1515
"@microsoft/api-extractor": "workspace:*",
1616
"@types/jest": "25.2.1",
17-
"@types/node": "10.17.13",
17+
"@types/node": "12.20.24",
1818
"fs-extra": "~7.0.1",
1919
"typescript": "~4.4.2"
2020
}

‎build-tests/api-extractor-scenarios/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@microsoft/teams-js": "1.3.0-beta.4",
1414
"@rushstack/node-core-library": "workspace:*",
1515
"@types/jest": "25.2.1",
16-
"@types/node": "10.17.13",
16+
"@types/node": "12.20.24",
1717
"api-extractor-lib1-test": "workspace:*",
1818
"api-extractor-lib2-test": "workspace:*",
1919
"api-extractor-lib3-test": "workspace:*",

‎build-tests/api-extractor-test-01/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"devDependencies": {
1717
"@microsoft/api-extractor": "workspace:*",
1818
"@types/heft-jest": "1.0.1",
19-
"@types/node": "10.17.13",
19+
"@types/node": "12.20.24",
2020
"fs-extra": "~7.0.1",
2121
"typescript": "~4.4.2"
2222
}

‎build-tests/api-extractor-test-02/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
},
1616
"devDependencies": {
1717
"@microsoft/api-extractor": "workspace:*",
18-
"@types/node": "10.17.13",
18+
"@types/node": "12.20.24",
1919
"fs-extra": "~7.0.1",
2020
"typescript": "~4.4.2"
2121
}

‎build-tests/api-extractor-test-03/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
},
99
"devDependencies": {
1010
"@types/jest": "25.2.1",
11-
"@types/node": "10.17.13",
11+
"@types/node": "12.20.24",
1212
"api-extractor-test-02": "workspace:*",
1313
"fs-extra": "~7.0.1",
1414
"typescript": "~4.4.2"

‎build-tests/heft-action-plugin/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"devDependencies": {
1212
"@rushstack/eslint-config": "workspace:*",
1313
"@rushstack/heft": "workspace:*",
14-
"@types/node": "10.17.13",
14+
"@types/node": "12.20.24",
1515
"eslint": "~7.30.0",
1616
"typescript": "~4.4.2"
1717
},

‎build-tests/heft-example-plugin-01/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"devDependencies": {
1616
"@rushstack/eslint-config": "workspace:*",
1717
"@rushstack/heft": "workspace:*",
18-
"@types/node": "10.17.13",
18+
"@types/node": "12.20.24",
1919
"@types/tapable": "1.0.6",
2020
"eslint": "~7.30.0",
2121
"typescript": "~4.4.2"

‎build-tests/heft-example-plugin-02/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"devDependencies": {
2121
"@rushstack/eslint-config": "workspace:*",
2222
"@rushstack/heft": "workspace:*",
23-
"@types/node": "10.17.13",
23+
"@types/node": "12.20.24",
2424
"eslint": "~7.30.0",
2525
"heft-example-plugin-01": "workspace:*",
2626
"typescript": "~4.4.2"

‎build-tests/heft-fastify-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@rushstack/eslint-config": "workspace:*",
1515
"@rushstack/heft": "workspace:*",
1616
"@types/heft-jest": "1.0.1",
17-
"@types/node": "10.17.13",
17+
"@types/node": "12.20.24",
1818
"eslint": "~7.30.0",
1919
"typescript": "~4.4.2"
2020
},

‎build-tests/heft-minimal-rig-usage-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"@rushstack/heft": "workspace:*",
1212
"@rushstack/heft-jest-plugin": "workspace:*",
1313
"@types/heft-jest": "1.0.1",
14-
"@types/node": "10.17.13",
14+
"@types/node": "12.20.24",
1515
"heft-minimal-rig-test": "workspace:*"
1616
}
1717
}

‎build-tests/heft-node-everything-esm-module-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"@rushstack/heft": "workspace:*",
1616
"@rushstack/heft-jest-plugin": "workspace:*",
1717
"@types/heft-jest": "1.0.1",
18-
"@types/node": "10.17.13",
18+
"@types/node": "12.20.24",
1919
"eslint": "~7.30.0",
2020
"heft-example-plugin-01": "workspace:*",
2121
"heft-example-plugin-02": "workspace:*",

‎build-tests/heft-node-everything-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"@rushstack/heft": "workspace:*",
1515
"@rushstack/heft-jest-plugin": "workspace:*",
1616
"@types/heft-jest": "1.0.1",
17-
"@types/node": "10.17.13",
17+
"@types/node": "12.20.24",
1818
"eslint": "~7.30.0",
1919
"heft-example-plugin-01": "workspace:*",
2020
"heft-example-plugin-02": "workspace:*",

‎build-tests/install-test-workspace/workspace/common/pnpm-lock.yaml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎build-tests/rush-project-change-analyzer-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"devDependencies": {
1515
"@rushstack/eslint-config": "workspace:*",
1616
"@rushstack/heft": "workspace:*",
17-
"@types/node": "10.17.13",
17+
"@types/node": "12.20.24",
1818
"@rushstack/heft-node-rig": "workspace:*"
1919
}
2020
}

‎build-tests/ts-command-line-test/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
},
1010
"devDependencies": {
1111
"@rushstack/ts-command-line": "workspace:*",
12-
"@types/node": "10.17.13",
12+
"@types/node": "12.20.24",
1313
"fs-extra": "~7.0.1",
1414
"typescript": "~4.4.2"
1515
}

0 commit comments

Comments
 (0)