Merge pull request microsoft#1826 from jkroepke/patch-1

iclanton · web-flow · commit 98fee0d1aae4 · 2020-04-13T18:30:50.000-07:00
[rush] Use `command` instead of `which`
diff --git a/apps/rush-lib/src/scripts/install-run.ts b/apps/rush-lib/src/scripts/install-run.ts
@@ -138,7 +138,7 @@ export function getNpmPath(): string {
         _npmPath = lines[lines.length - 1];
       } else {
         // We aren't on Windows - assume we're on *NIX or Darwin
-        _npmPath = childProcess.execSync('which npm', { stdio: [] }).toString();
+        _npmPath = childProcess.execSync('command -v npm', { stdio: [] }).toString();
       }
     } catch (e) {
       throw new Error(`Unable to determine the path to the NPM tool: ${e}`);
diff --git a/common/changes/@microsoft/rush/patch-1_2020-04-11-10-11.json b/common/changes/@microsoft/rush/patch-1_2020-04-11-10-11.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "packageName": "@microsoft/rush",
+      "comment": "Fix an issue where, on some minimal systems, Rush used a missing shell command to detect an application path.",
+      "type": "none"
+    }
+  ],
+  "packageName": "@microsoft/rush",
+  "email": "mail@jkroepke.de"
+}

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ export function getNpmPath(): string {`
`138`	`138`	`_npmPath = lines[lines.length - 1];`
`139`	`139`	`} else {`
`140`	`140`	`// We aren't on Windows - assume we're on *NIX or Darwin`
`141`		`- _npmPath = childProcess.execSync('which npm', { stdio: [] }).toString();`
	`141`	`+ _npmPath = childProcess.execSync('command -v npm', { stdio: [] }).toString();`
`142`	`142`	`}`
`143`	`143`	`} catch (e) {`
`144`	`144`	throw new Error(`Unable to determine the path to the NPM tool: ${e}`);