Fix linting issues

ejsmith · niemyjski · commit 111f0a9cddbc · 2021-06-22T08:28:33.000-05:00
diff --git a/packages/browser/src/plugins/BrowserGlobalHandlerPlugin.ts b/packages/browser/src/plugins/BrowserGlobalHandlerPlugin.ts
@@ -20,11 +20,11 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
     this._client = context.client;
 
     // TODO: Discus if we want to unwire this handler in suspend?
-    window.addEventListener("error", async event => {
-      await this._client.submitUnhandledException(this.getError(event), "onerror");
+    window.addEventListener("error", event => {
+      void this._client.submitUnhandledException(this.getError(event), "onerror");
     });
 
-    window.addEventListener("unhandledrejection", async event => {
+    window.addEventListener("unhandledrejection", event => {
       let error = event.reason;
       try {
         // eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
@@ -35,7 +35,7 @@ export class BrowserGlobalHandlerPlugin implements IEventPlugin {
         // eslint-disable-next-line no-empty
       } catch (ex) { }
 
-      await this._client.submitUnhandledException(error, "onunhandledrejection");
+      void this._client.submitUnhandledException(error, "onunhandledrejection");
     });
 
 
diff --git a/packages/browser/src/plugins/BrowserLifeCyclePlugin.ts b/packages/browser/src/plugins/BrowserLifeCyclePlugin.ts
@@ -17,12 +17,12 @@ export class BrowserLifeCyclePlugin implements IEventPlugin {
 
     this._client = context.client;
 
-    globalThis.addEventListener("beforeunload", async () => await this._client.suspend());
-    document.addEventListener("visibilitychange", async () => {
+    globalThis.addEventListener("beforeunload", () => void this._client.suspend());
+    document.addEventListener("visibilitychange", () => {
       if (document.visibilityState === 'visible') {
-        await this._client.startup()
+        void this._client.startup()
       } else {
-        await this._client.suspend()
+        void this._client.suspend()
       }
     });
 
diff --git a/packages/core/src/plugins/default/DuplicateCheckerPlugin.ts b/packages/core/src/plugins/default/DuplicateCheckerPlugin.ts
@@ -50,7 +50,7 @@ export class DuplicateCheckerPlugin implements IEventPlugin {
       return hash;
     }
 
-    const error = context.event.data![KnownEventDataKeys.Error];
+    const error = context.event.data[KnownEventDataKeys.Error];
     const hashCode = calculateHashCode(error);
     if (hashCode) {
       const count = context.event.count || 1;
diff --git a/packages/core/src/plugins/default/EventExclusionPlugin.ts b/packages/core/src/plugins/default/EventExclusionPlugin.ts
@@ -14,14 +14,14 @@ export class EventExclusionPlugin implements IEventPlugin {
 
     if (ev.type === "log") {
       const minLogLevel = this.getMinLogLevel(settings, ev.source);
-      const logLevel = this.getLogLevel(ev.data![KnownEventDataKeys.Level]);
+      const logLevel = this.getLogLevel(ev.data[KnownEventDataKeys.Level]);
 
       if (logLevel !== -1 && (logLevel === 6 || logLevel < minLogLevel)) {
         log.info("Cancelling log event due to minimum log level.");
         context.cancelled = true;
       }
     } else if (ev.type === "error") {
-      let error = ev.data![KnownEventDataKeys.Error];
+      let error = ev.data[KnownEventDataKeys.Error];
       while (!context.cancelled && error) {
         if (this.getTypeAndSourceSetting(settings, ev.type, error.type, true) === false) {
           log.info(`Cancelling error from excluded exception type: ${error.type}`);
diff --git a/packages/core/src/plugins/default/HeartbeatPlugin.ts b/packages/core/src/plugins/default/HeartbeatPlugin.ts
@@ -30,10 +30,10 @@ export class HeartbeatPlugin implements IEventPlugin {
     clearInterval(this._intervalId);
     this._intervalId = 0;
 
-    const user = context.event.data![KnownEventDataKeys.UserInfo];
+    const user = context.event.data[KnownEventDataKeys.UserInfo];
     if (user?.identity) {
       this._intervalId = setInterval(
-        async () => await context.client.submitSessionHeartbeat(user.identity),
+        () => void context.client.submitSessionHeartbeat(user.identity),
         this._interval,
       );
     }
diff --git a/packages/core/src/plugins/default/SubmissionMethodPlugin.ts b/packages/core/src/plugins/default/SubmissionMethodPlugin.ts
@@ -9,7 +9,7 @@ export class SubmissionMethodPlugin implements IEventPlugin {
   public run(context: EventPluginContext): Promise<void> {
     const submissionMethod = context.contextData.getSubmissionMethod();
     if (submissionMethod) {
-      context.event.data![KnownEventDataKeys.SubmissionMethod] = submissionMethod;
+      context.event.data[KnownEventDataKeys.SubmissionMethod] = submissionMethod;
     }
 
     return Promise.resolve();
diff --git a/packages/node/test/storage/NodeFileStorage.test.ts b/packages/node/test/storage/NodeFileStorage.test.ts
@@ -1,6 +1,6 @@
-import { IStorage } from "@exceptionless/core";
+import { IStorage, LocalStorage } from "@exceptionless/core";
 import { describeStorage } from "../../../core/test/storage/StorageTestBase.js";
-import { NodeFileStorage } from "../../src/storage/NodeFileStorage.js";
+import { LocalStorage as LocalStoragePolyfill } from "node-localstorage";
 
 import {
   mkdirSync,
@@ -15,7 +15,7 @@ function resetStorageDirectory() {
 const directory: string = "./test/data";
 describeStorage(
   "NodeFileStorage",
-  (): IStorage => new NodeFileStorage(directory),
+  (): IStorage => new LocalStorage(undefined, new LocalStoragePolyfill(directory)),
   resetStorageDirectory,
   resetStorageDirectory
 );

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ export class DuplicateCheckerPlugin implements IEventPlugin {`
`50`	`50`	`return hash;`
`51`	`51`	`}`
`52`	`52`
`53`		`- const error = context.event.data![KnownEventDataKeys.Error];`
	`53`	`+ const error = context.event.data[KnownEventDataKeys.Error];`
`54`	`54`	`const hashCode = calculateHashCode(error);`
`55`	`55`	`if (hashCode) {`
`56`	`56`	`const count = context.event.count \|\| 1;`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export class SubmissionMethodPlugin implements IEventPlugin {`
`9`	`9`	`public run(context: EventPluginContext): Promise<void> {`
`10`	`10`	`const submissionMethod = context.contextData.getSubmissionMethod();`
`11`	`11`	`if (submissionMethod) {`
`12`		`- context.event.data![KnownEventDataKeys.SubmissionMethod] = submissionMethod;`
	`12`	`+ context.event.data[KnownEventDataKeys.SubmissionMethod] = submissionMethod;`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`return Promise.resolve();`